public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* check-localplt failures for Powerpc
@ 2007-09-21 19:56 Steven Munroe
  2007-09-21 20:27 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Munroe @ 2007-09-21 19:56 UTC (permalink / raw)
  To: GNU libc hacker, Roland McGrath; +Cc: Ryan Arnold

[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]

I am seeing make check failures for powerpc32/powerpc64 with current CVS
in check-localplt. Looks like the precipitating change went in August 6th.

2007-08-06  Roland McGrath  <roland@redhat.com>

    * scripts/data/localplt-powerpc-linux-gnu.data: New file.

    * scripts/data/localplt-x86_64-linux-gnu.data: File renamed to ...
    * scripts/data/localplt-generic.data: ... here.
    * elf/Makefile (check-data): Get generic file if no other.
    ($(objpfx)check-localplt.out): Make target unconditional.

Check-localplt seens to be looking for PLT entries that are locally
defined. But I can find no discussion on the mlists for what exactly we
are looking for or what the corrective action should be.

powerpc is hiting this becuase of differences in long double handling
and recent fenv changes. Also there are some difference between
powerpc32 and powerpc64 due to the difference in sizeof(long) and
_Unwind_Find_FDE.

The attached patch elliminates the make check failures by updating
scripts/data/localplt-powerpc-linux-gnu.data and adding
scripts/data/localplt-powerpc64-linux-gnu.data.

If this is not the appropriate corrective action, please let me know.

[-- Attachment #2: ppc-check-localplt-20070919.txt --]
[-- Type: text/plain, Size: 1688 bytes --]

2007-09-19  Steven Munroe  <sjmunroe@us.ibm.com>

	* scripts/data/localplt-powerpc-linux-gnu.data: Add symbols for 
	long double and fe*except handling.
	* scripts/data/localplt-powerpc64-linux-gnu.data: New file.

diff -urN libc25-cvstip-20070919/scripts/data/localplt-powerpc-linux-gnu.data libc25/scripts/data/localplt-powerpc-linux-gnu.data
--- libc25-cvstip-20070919/scripts/data/localplt-powerpc-linux-gnu.data	2007-08-07 00:36:08.000000000 -0500
+++ libc25/scripts/data/localplt-powerpc-linux-gnu.data	2007-09-20 10:58:19.846924800 -0500
@@ -1,7 +1,23 @@
 libc.so: _Unwind_Find_FDE
+libc.so: __signbitl
 libc.so: calloc
 libc.so: free
 libc.so: malloc
 libc.so: memalign
 libc.so: realloc
+libm.so: __fe_nomask_env
+libm.so: __signbitl
+libm.so: cosl
+libm.so: fegetexcept
+libm.so: fetestexcept
+libm.so: finitel
+libm.so: frexpl
+libm.so: ilogbl
+libm.so: ldexpl
+libm.so: logl
+libm.so: lroundl
 libm.so: matherr
+libm.so: nextafter
+libm.so: roundl
+libm.so: sinl
+libm.so: sqrtl
diff -urN libc25-cvstip-20070919/scripts/data/localplt-powerpc64-linux-gnu.data libc25/scripts/data/localplt-powerpc64-linux-gnu.data
--- libc25-cvstip-20070919/scripts/data/localplt-powerpc64-linux-gnu.data	Wed Dec 31 18:00:00 1969
+++ libc25/scripts/data/localplt-powerpc64-linux-gnu.data	Thu Sep 20 11:15:33 2007
@@ -0,0 +1,20 @@
+libc.so: __signbitl
+libc.so: calloc
+libc.so: free
+libc.so: malloc
+libc.so: memalign
+libc.so: realloc
+libm.so: __fe_nomask_env
+libm.so: __signbitl
+libm.so: cosl
+libm.so: fegetexcept
+libm.so: fetestexcept
+libm.so: finitel
+libm.so: frexpl
+libm.so: ilogbl
+libm.so: ldexpl
+libm.so: logl
+libm.so: matherr
+libm.so: roundl
+libm.so: sinl
+libm.so: sqrtl

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-21 20:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-21 19:56 check-localplt failures for Powerpc Steven Munroe
2007-09-21 20:27 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).