From: Ulrich Drepper <drepper@redhat.com>
To: libc-hacker@sourceware.org
Subject: Re: [PATCH] Avoid PLT call to fegetenv on s390
Date: Sat, 06 Feb 2010 10:23:00 -0000 [thread overview]
Message-ID: <4B6D4326.1050403@redhat.com> (raw)
In-Reply-To: <m3pr4whgp5.fsf@hase.home>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/26/2010 10:19 AM, Andreas Schwab wrote:
> * include/fenv.h: Add hidden proto for fegetenv.
> * sysdeps/s390/fpu/fegetenv.c: Add hidden alias. Remove unused
> headers.
This cannot be right. You're changing only one of the many fegetenv.c
files. It might accidentally since on other archs the functions isn't
used internally. But it still should be done correctly.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkttQyYACgkQ2ijCOnn/RHRZxwCcCOzNjsBouk/A1N0+YczntXh4
XOUAoKudJIPtybIFIgkWVjhI0+pIPffe
=NvgI
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-02-06 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 18:19 Andreas Schwab
2010-02-06 10:23 ` Ulrich Drepper [this message]
2010-02-08 12:17 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6D4326.1050403@redhat.com \
--to=drepper@redhat.com \
--cc=libc-hacker@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).