From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8205 invoked by alias); 6 Feb 2010 10:23:43 -0000 Received: (qmail 8184 invoked by uid 22791); 6 Feb 2010 10:23:42 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 06 Feb 2010 10:23:39 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o16ANbFT010411 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 6 Feb 2010 05:23:37 -0500 Received: from x61.akkadia.org (vpn2-9-145.ams2.redhat.com [10.36.9.145]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o16ANZKH004976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 6 Feb 2010 05:23:36 -0500 Message-ID: <4B6D4326.1050403@redhat.com> Date: Sat, 06 Feb 2010 10:23:00 -0000 From: Ulrich Drepper User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de-DE; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.1 MIME-Version: 1.0 To: libc-hacker@sourceware.org Subject: Re: [PATCH] Avoid PLT call to fegetenv on s390 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00001.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 01/26/2010 10:19 AM, Andreas Schwab wrote: > * include/fenv.h: Add hidden proto for fegetenv. > * sysdeps/s390/fpu/fegetenv.c: Add hidden alias. Remove unused > headers. This cannot be right. You're changing only one of the many fegetenv.c files. It might accidentally since on other archs the functions isn't used internally. But it still should be done correctly. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkttQyYACgkQ2ijCOnn/RHRZxwCcCOzNjsBouk/A1N0+YczntXh4 XOUAoKudJIPtybIFIgkWVjhI0+pIPffe =NvgI -----END PGP SIGNATURE-----