From: Ulrich Drepper <drepper@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: libc-hacker@sourceware.org
Subject: Re: [PATCH] Don't call uname or getrlimit in libpthread init function
Date: Thu, 08 Apr 2010 23:42:00 -0000 [thread overview]
Message-ID: <4BBE69D7.7030009@redhat.com> (raw)
In-Reply-To: <m2y6gxy1po.fsf@igel.home>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 04/08/2010 04:16 PM, Andreas Schwab wrote:
> The last time I checked, uname was not in C99.
Neither is POSIX threads. If you link with the DSO you're leaving ISO C
territory.
And moreover: when you define a function umask in your program (= the
executable) nothing bad will happen. Preloading, as in this case, is
something completely different.
This is just another precedence for somebody doing stupid things and
expecting nothing to break. It's just a bad idea to encourage this. If
you replace a function then do it right and everything will work
correctly. If the floodgates for these kinds of changes would be opened
we would have to add a whole lot of symbols to libc.so. This doesn't
come without a cost.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA â–
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAku+adcACgkQ2ijCOnn/RHQvZACggj8GMPsaR0Q/sVuyjMuGmVZI
fMcAmQGquepfyCfImc3ChYoFdJtsIcVs
=GG1m
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-04-08 23:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 9:43 Andreas Schwab
2010-04-08 22:36 ` Ulrich Drepper
[not found] ` <m2y6gxy1po.fsf@igel.home>
2010-04-08 23:42 ` Ulrich Drepper [this message]
2010-04-09 8:18 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE69D7.7030009@redhat.com \
--to=drepper@redhat.com \
--cc=libc-hacker@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).