public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] powerpc32: add fanotify_mark syscall
@ 2010-08-19 14:03 Andreas Schwab
  2010-08-19 14:45 ` Ulrich Drepper
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2010-08-19 14:03 UTC (permalink / raw)
  To: libc-hacker

2010-08-19  Andreas Schwab  <schwab@redhat.com>

	* sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list: Add
	fanotify_mark.
---
 .../sysv/linux/powerpc/powerpc32/syscalls.list     |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list b/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list
index 3012285..aaa3557 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list
@@ -8,3 +8,4 @@ oldsetrlimit	EXTRA	setrlimit	i:ip	__old_setrlimit	setrlimit@GLIBC_2.0
 readahead	-	readahead	i:iiiii	__readahead	readahead
 
 prlimit64	EXTRA	prlimit64	i:iipp	prlimit64
+fanotify_mark	EXTRA	fanotify_mark	i:iiiiis	fanotify_mark
-- 
1.7.2.1

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc32: add fanotify_mark syscall
  2010-08-19 14:03 [PATCH] powerpc32: add fanotify_mark syscall Andreas Schwab
@ 2010-08-19 14:45 ` Ulrich Drepper
  2010-08-19 14:49   ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: Ulrich Drepper @ 2010-08-19 14:45 UTC (permalink / raw)
  To: libc-hacker

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/19/2010 07:03 AM, Andreas Schwab wrote:
> +fanotify_mark	EXTRA	fanotify_mark	i:iiiiis	fanotify_mark


Are you sure?  I didn't add anything like this because the kernel entry
for 32-bit expects the mask in two halves.  These are passed correctly
for x86 but I don't think it works without a wrapper on big endian.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAkxtQ2MACgkQ2ijCOnn/RHS5sQCfRfH/xRQHzFRIarU9XfKA1aXz
09kAn1gIfELhYWKn7HMHGahSUHOChVAa
=/uWN
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc32: add fanotify_mark syscall
  2010-08-19 14:45 ` Ulrich Drepper
@ 2010-08-19 14:49   ` Andreas Schwab
  2010-08-19 14:54     ` Ulrich Drepper
  0 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2010-08-19 14:49 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: libc-hacker

Ulrich Drepper <drepper@redhat.com> writes:

> On 08/19/2010 07:03 AM, Andreas Schwab wrote:
>> +fanotify_mark	EXTRA	fanotify_mark	i:iiiiis	fanotify_mark
>
>
> Are you sure?  I didn't add anything like this because the kernel entry
> for 32-bit expects the mask in two halves.

Which is exactly what it does.  Count the letters.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc32: add fanotify_mark syscall
  2010-08-19 14:49   ` Andreas Schwab
@ 2010-08-19 14:54     ` Ulrich Drepper
  2010-08-19 14:58       ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: Ulrich Drepper @ 2010-08-19 14:54 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/19/2010 07:49 AM, Andreas Schwab wrote:
> Which is exactly what it does.  Count the letters.

That's not what I meant.  It's the order of the two halves.  Works for
little endian If I got it right and big endian needs a wrapper.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAkxtRYMACgkQ2ijCOnn/RHSXcQCgpbaOuhD5JxaWJfh6/cJrE6+b
huEAoKr5JcAGm5Bx3uLhh1kQkLoCdub/
=SHUy
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] powerpc32: add fanotify_mark syscall
  2010-08-19 14:54     ` Ulrich Drepper
@ 2010-08-19 14:58       ` Andreas Schwab
  0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2010-08-19 14:58 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: libc-hacker

Ulrich Drepper <drepper@redhat.com> writes:

> big endian needs a wrapper.

Since when is the kernel little endian?

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-08-19 14:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-19 14:03 [PATCH] powerpc32: add fanotify_mark syscall Andreas Schwab
2010-08-19 14:45 ` Ulrich Drepper
2010-08-19 14:49   ` Andreas Schwab
2010-08-19 14:54     ` Ulrich Drepper
2010-08-19 14:58       ` Andreas Schwab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).