From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7325 invoked by alias); 16 May 2003 13:14:07 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 7302 invoked from network); 16 May 2003 13:14:06 -0000 Received: from unknown (HELO linuxpc1.lauterbach.com) (213.70.137.66) by sources.redhat.com with SMTP; 16 May 2003 13:14:06 -0000 Received: (qmail 16340 invoked by uid 82); 16 May 2003 13:14:05 -0000 Received: from Franz.Sirl-kernel@lauterbach.com by linuxpc1 by uid 80 with qmail-scanner-1.15 (inocmd32: virsig.da0 23.58.28 . spamassassin: 2.43-cvs. Clear:. Processed in 1.410084 secs); 16 May 2003 13:14:05 -0000 Received: from frapc1.lauterbach.com (10.1.0.31) by linuxpc1.lauterbach.com with SMTP; 16 May 2003 13:14:04 -0000 Message-Id: <5.2.1.1.2.20030516151032.03505350@mail.lauterbach.com> X-Sender: fsirl-kernel@mail.lauterbach.com Date: Fri, 16 May 2003 13:14:00 -0000 To: Jakub Jelinek From: Franz Sirl Subject: Re: [PATCH] Fix ppc32 ld.so Cc: Ulrich Drepper ,Roland McGrath , Jack Howarth , Glibc hackers In-Reply-To: <20030515151608.GX16629@sunsite.ms.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-SW-Source: 2003-05/txt/msg00025.txt.bz2 At 17:16 15.05.2003, Jakub Jelinek wrote: >Hi! > >This is something I cannot understand how it ever worked. >If there is a reloc overflow on ppc32, _dl_reloc_overflow tries to print the >name of the symbol. But unless sym is NULL (and thus errsym = refsym) resp. >equal to refsym, it will print something from the refsym's strtab at index >sym->st_name, ie. a random string at best, worst case segfault. >To print sym's name instead of refsym's (though I don't understand why that >is needed, both sym and refsym ought to always have the same symbol name, >otherwise symbol lookup is broken) we'd have to pass down sym_map as well, >but sym_map is not always computed (ATM only if --with-tls). Hmm, IIRC that was a mere result of try and error. I think I used the first version that produced sensible results with the (small) binutils testcases. Certainly you have more insight in that relocation code and I believe you if you say that it just worked by luck :-). Franz.