From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20383 invoked by alias); 11 Mar 2004 09:40:45 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 20365 invoked from network); 11 Mar 2004 09:40:44 -0000 Received: from unknown (HELO mtagate2.de.ibm.com) (195.212.29.151) by sources.redhat.com with SMTP; 11 Mar 2004 09:40:44 -0000 Received: from d12relay02.megacenter.de.ibm.com (d12relay02.megacenter.de.ibm.com [9.149.165.196]) by mtagate2.de.ibm.com (8.12.10/8.12.10) with ESMTP id i2B9eZKG127758; Thu, 11 Mar 2004 09:40:35 GMT Received: from d12ml062.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12relay02.megacenter.de.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id i2B9eZbg265082; Thu, 11 Mar 2004 10:40:36 +0100 Subject: Re: [PATCH] Fix s390{,x} build To: Jakub Jelinek Cc: Ulrich Drepper , Glibc hackers Message-ID: From: Martin Schwidefsky Date: Thu, 11 Mar 2004 09:40:00 -0000 MIME-Version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: quoted-printable X-SW-Source: 2004-03/txt/msg00066.txt.bz2 Hi Jakub, > The recent dl-tls.c -> dl-sym.c reshuffling broke s390*. > Here is a fix, verified so far with doing dlsym on a STT_TLS symbol > in a shared library. I was just trying to get this fixed myself. Jakub was (again) faster and his solution is better than mine. My solution exports __tls_get_addr as second interface which isn't nice. The __tls_get_offset should be the only interface because __tls_get_addr doesn't return the address to the variable but the offset of the variable to the thread pointer. This can be very confusing. blue skies, Martin Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH Sch=F6naicherstr. 220, D-71032 B=F6blingen, Telefon: 49 - (0)7031 - 16-2247 E-Mail: schwidefsky@de.ibm.com