From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18433 invoked by alias); 27 Jan 2004 14:43:35 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 18417 invoked from network); 27 Jan 2004 14:43:34 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sources.redhat.com with SMTP; 27 Jan 2004 14:43:34 -0000 Received: from Hermes.suse.de (Hermes.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 8D58955E34; Tue, 27 Jan 2004 15:43:34 +0100 (CET) Received: by reger.suse.de (Postfix, from userid 659) id A17B1D0863; Tue, 27 Jan 2004 15:43:31 +0100 (CET) To: Ulrich Drepper Cc: Glibc hackers , Paul Eggert Subject: Re: Import obstack.* from gnulib References: <4012E4BB.9070807@redhat.com> <40137DCB.7010309@redhat.com> From: Andreas Jaeger Date: Tue, 27 Jan 2004 14:43:00 -0000 In-Reply-To: <40137DCB.7010309@redhat.com> (Ulrich Drepper's message of "Sun, 25 Jan 2004 00:26:51 -0800") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2004-01/txt/msg00106.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2213 Paul Eggert wrote the following: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > From: Ulrich Drepper > Date: Sat, 24 Jan 2004 13:33:47 -0800 >=20 > > @@ -119,40 +119,22 @@ extern "C" { > > #endif > >=20=20 > > #ifndef __INT_TO_PTR > > -#if defined __STDC__ && __STDC__ > > -# define __INT_TO_PTR(P) ((void *) ((P) + (char *) 0)) > > -#else > > # define __INT_TO_PTR(P) ((P) + (char *) 0) > > #endif > > -#endif > > Why should the K&R branch survive here? Because the "ANSI branch" was incorrect for C++ compilation. This problem was originally described by Alexandre Duret-Lutz in . The above-quoted hunk isn't complete by itself. It's paired with the following change to obstack_finish: - __INT_TO_PTR ((h)->temp)) + (void *) __INT_TO_PTR ((h)->temp)) and this pair of hunks causes the resulting code to conform to C89 (as well as to C99; and to K&R C also, not that it matters). > Maybe there are other places like this. No. I didn't find any other places when I looked for them. This was in July when I installed this patch into gnulib . Also, the patch worked for Alexandre, which is a test that the changes are complete. > From: Ulrich Drepper > Date: Sun, 25 Jan 2004 00:26:51 -0800 >=20 > Andreas Jaeger wrote: > > I suggest to import this now - and handle those changes later. Ok? >=20 > No, why? We don't add incomplete changes since this only means it gets > forgotten. Andreas, I assume that by "those changes later" you mean some other set of changes for the "other places like this". If I understand you correctly, there are no "those changes". Your email contained only one set of changes, which are complete. There is no K&R code in the resulting file. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So, can I commit the current version now? Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SuSE Linux AG, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQBAFnkTOJpWPMJyoSYRAiM4AJwIqmuKTlxIFhT2+hxtcbWfxOQuRACfYl20 lfcjWIIGdixpRZrdg+HjOzQ= =N/Mh -----END PGP SIGNATURE----- --=-=-=--