From: Andreas Jaeger <aj@suse.de>
To: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Add missing extern
Date: Thu, 16 Aug 2007 07:18:00 -0000 [thread overview]
Message-ID: <ho7inwrlpu.fsf@reger.suse.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]
In our bugzilla we got a report that an extern is missing (for details:
https://bugzilla.novell.com/show_bug.cgi?id=233835).
This results on static linking with -Wl,-warn-common in lots of these
warnings:
/usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(strtod_l.o): warning: common of `_nl_category_name_idxs' overridden by definition
/usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(setlocale.o): warning: defined here
/usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(mbrtowc.o): warning: multiple common of `_nl_category_name_idxs'
Ok to commit?
Andreas
2007-08-16 Andreas Jaeger <aj@suse.de>
* locale/localeinfo.h: Make _nl_category_name_idxs extern.
Reported by Peter Festner <peter.festner@ewetel.net>.
Index: locale/localeinfo.h
===================================================================
RCS file: /cvs/glibc/libc/locale/localeinfo.h,v
retrieving revision 1.59
diff -u -p -r1.59 localeinfo.h
--- locale/localeinfo.h 27 Oct 2006 23:11:43 -0000 1.59
+++ locale/localeinfo.h 16 Aug 2007 06:52:15 -0000
@@ -186,7 +186,7 @@ extern const union catnamestr_t
};
char str[0];
} _nl_category_names attribute_hidden;
-const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden;
+extern const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden;
extern const uint8_t _nl_category_name_sizes[__LC_LAST] attribute_hidden;
/* Name of the standard locales. */
--
Andreas Jaeger, Director Platform / openSUSE, aj@suse.de
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
next reply other threads:[~2007-08-16 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 7:18 Andreas Jaeger [this message]
2007-08-16 20:53 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ho7inwrlpu.fsf@reger.suse.de \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).