From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20692 invoked by alias); 16 Aug 2007 07:18:47 -0000 Received: (qmail 20469 invoked by uid 22791); 16 Aug 2007 07:18:46 -0000 X-Spam-Check-By: sourceware.org Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 16 Aug 2007 07:18:42 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 69FE5125C8 for ; Thu, 16 Aug 2007 09:18:39 +0200 (CEST) From: Andreas Jaeger To: GNU libc hackers Subject: Add missing extern OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Thu, 16 Aug 2007 07:18:00 -0000 Message-ID: User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00025.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1851 In our bugzilla we got a report that an extern is missing (for details: https://bugzilla.novell.com/show_bug.cgi?id=3D233835). This results on static linking with -Wl,-warn-common in lots of these warnings: /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(strtod_l.o)= : warning: common of `_nl_category_name_idxs' overridden by definition /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(setlocale.o= ): warning: defined here /usr/lib64/gcc/x86_64-suse-linux/4.1.2/../../../../lib64/libc.a(mbrtowc.o):= warning: multiple common of `_nl_category_name_idxs' Ok to commit? Andreas 2007-08-16 Andreas Jaeger * locale/localeinfo.h: Make _nl_category_name_idxs extern. Reported by Peter Festner . Index: locale/localeinfo.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/glibc/libc/locale/localeinfo.h,v retrieving revision 1.59 diff -u -p -r1.59 localeinfo.h --- locale/localeinfo.h 27 Oct 2006 23:11:43 -0000 1.59 +++ locale/localeinfo.h 16 Aug 2007 06:52:15 -0000 @@ -186,7 +186,7 @@ extern const union catnamestr_t }; char str[0]; } _nl_category_names attribute_hidden; -const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden; +extern const uint8_t _nl_category_name_idxs[__LC_LAST] attribute_hidden; extern const uint8_t _nl_category_name_sizes[__LC_LAST] attribute_hidden; =20 /* Name of the standard locales. */ --=20 Andreas Jaeger, Director Platform / openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFGw/pNOJpWPMJyoSYRAm16AJ4joPKExpl3iS6Yf2e+1wDcjzlPvQCfbHfp G+fZBRxvlj5ufonn2e99t7I= =v2Rw -----END PGP SIGNATURE----- --=-=-=--