From: Andreas Jaeger <aj@suse.de>
To: Roland McGrath <roland@redhat.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: make check failure on x86-64 with abilist
Date: Wed, 19 Mar 2003 11:05:00 -0000 [thread overview]
Message-ID: <ho8yvbtya5.fsf@byrd.suse.de> (raw)
In-Reply-To: <200303191053.h2JArvj24287@magilla.sf.frob.com> (Roland McGrath's message of "Wed, 19 Mar 2003 02:53:57 -0800")
Roland McGrath <roland@redhat.com> writes:
>> So, should we make it internal now? I don't see where it's used and
>> it's not exported in /usr/include.
>
> Sounds fine to me.
Patch is appended. Ok to commit?
>> Btw. make check will always abort if the abi check fails, it's not
>> possible to rerun make check and continue - like it's done with all
>> other tests that create a .out file,
>
> That means you didn't lose anything. make check will always update all
> .out files, and then do check-abi (show you the diff).
Excellent!
Andreas
2003-03-19 Andreas Jaeger <aj@suse.de>
* intl/Versions: Make _nl_msg_cat_cntr, _nl_default_dirname and
_nl_domain_bindings as private.
============================================================
Index: intl/Versions
--- intl/Versions 1 May 2002 16:42:08 -0000 1.4
+++ intl/Versions 19 Mar 2003 11:01:08 -0000
@@ -1,8 +1,5 @@
libc {
GLIBC_2.0 {
- # global variables
- _nl_msg_cat_cntr; _nl_default_dirname; _nl_domain_bindings;
-
# functions used in inline functions or macros
__dcgettext;
@@ -27,5 +24,9 @@ libc {
# n*
ngettext;
+ }
+ GLIBC_PRIVATE {
+ # global variables
+ _nl_msg_cat_cntr; _nl_default_dirname; _nl_domain_bindings;
}
}
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj
next prev parent reply other threads:[~2003-03-19 11:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-19 9:36 Andreas Jaeger
2003-03-19 9:44 ` Jakub Jelinek
2003-03-19 10:31 ` Andreas Jaeger
2003-03-19 10:50 ` Roland McGrath
2003-03-19 10:53 ` Andreas Jaeger
2003-03-19 11:02 ` Roland McGrath
2003-03-19 11:05 ` Andreas Jaeger [this message]
2003-03-19 11:13 ` Roland McGrath
2003-03-19 12:22 ` Andreas Schwab
2003-03-19 12:55 ` Andreas Jaeger
2003-03-19 14:29 ` Andreas Schwab
2003-03-19 17:24 ` Andreas Jaeger
2003-03-19 17:31 ` Ulrich Drepper
2003-03-19 22:06 ` Jakub Jelinek
2003-03-22 23:41 ` Andreas Jaeger
2003-03-19 17:24 ` Ulrich Drepper
2003-03-19 17:25 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ho8yvbtya5.fsf@byrd.suse.de \
--to=aj@suse.de \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).