public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Get rid of warning in linuxthreads/spinlock.c
Date: Thu, 22 Jan 2004 11:03:00 -0000	[thread overview]
Message-ID: <hoisj42qo9.fsf@reger.suse.de> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 259 bytes --]


this patch gets rid of:

spinlock.c:33: warning: matching constraint does not allow a register

Ok to commit?
Andreas

2004-01-22  Andreas Jaeger  <aj@suse.de>

	* spinlock.c (__pthread_lock): Fix contraint to avoid warning.
	(__pthread_release): Likewise.


[-- Attachment #1.2: libc-diff --]
[-- Type: text/plain, Size: 802 bytes --]

============================================================
Index: linuxthreads/spinlock.c
--- linuxthreads/spinlock.c	29 Aug 2002 10:32:19 -0000	1.37
+++ linuxthreads/spinlock.c	22 Jan 2004 11:00:37 -0000
@@ -30,7 +30,7 @@ static inline void __pthread_release(int
 {
   WRITE_MEMORY_BARRIER();
   *spinlock = __LT_SPINLOCK_INIT;
-  __asm __volatile ("" : "=m" (*spinlock) : "0" (*spinlock));
+  __asm __volatile ("" : "=m" (*spinlock) : "m" (*spinlock));
 }
 
 
@@ -106,7 +106,7 @@ void internal_function __pthread_lock(st
 #ifdef BUSY_WAIT_NOP
       BUSY_WAIT_NOP;
 #endif
-      __asm __volatile ("" : "=m" (lock->__status) : "0" (lock->__status));
+      __asm __volatile ("" : "=m" (lock->__status) : "m" (lock->__status));
     }
 
     lock->__spinlock += (spin_count - lock->__spinlock) / 8;

[-- Attachment #1.3: Type: text/plain, Size: 192 bytes --]



-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

             reply	other threads:[~2004-01-22 11:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-22 11:03 Andreas Jaeger [this message]
2004-01-22 23:12 ` Roland McGrath
2004-01-23 13:17   ` Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hoisj42qo9.fsf@reger.suse.de \
    --to=aj@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).