From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6757 invoked by alias); 23 Oct 2007 07:04:43 -0000 Received: (qmail 6738 invoked by uid 22791); 23 Oct 2007 07:04:42 -0000 X-Spam-Check-By: sourceware.org Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 23 Oct 2007 07:04:39 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 0C0B3150F1 for ; Tue, 23 Oct 2007 09:04:37 +0200 (CEST) From: Andreas Jaeger To: GNU libc hackers Subject: Fix PR 5208 - readahead OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Tue, 23 Oct 2007 07:04:00 -0000 Message-ID: User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00021.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1604 The system call parameters are wrong for little endian. Ok to commit to both 2.7 and HEAD? Andreas 2007-10-23 Andreas Jaeger [BZ #5208] * sysdeps/unix/sysv/linux/readahead.c (__readahead): Use __LONG_LONG_PAIR to handle little endian byte order. Suggested by abhishekrai@google.com =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Index: sysdeps/unix/sysv/linux/readahead.c --- sysdeps/unix/sysv/linux/readahead.c 20 Jan 2004 23:21:34 -0000 1.3 +++ sysdeps/unix/sysv/linux/readahead.c 23 Oct 2007 07:03:51 -0000 @@ -1,5 +1,5 @@ /* Provide kernel hint to read ahead. - Copyright (C) 2002, 2003, 2004 Free Software Foundation, Inc. + Copyright (C) 2002, 2003, 2004, 2007 Free Software Foundation, Inc. This file is part of the GNU C Library. =20 The GNU C Library is free software; you can redistribute it and/or @@ -30,8 +30,10 @@ ssize_t __readahead (int fd, off64_t offset, size_t count) { - return INLINE_SYSCALL (readahead, 4, fd, (off_t) (offset >> 32), - (off_t) (offset & 0xffffffff), count); + return INLINE_SYSCALL (readahead, 4, fd,=20 + __LONG_LONG_PAIR ((off_t) (offset >> 32), + (off_t) (offset & 0xffffffff)),=20 + count); } #else ssize_t --=20 Andreas Jaeger, Director Platform / openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 193 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) iD8DBQFHHZ0DOJpWPMJyoSYRAubjAJ477tGxZDl9lCsJSULfu0L+wnylngCfUzLW N57zYVEfwCEQe7DdYuNaINc= =+T3r -----END PGP SIGNATURE----- --=-=-=--