public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: Roland McGrath <roland@redhat.com>
Cc: libc-hacker@sources.redhat.com
Subject: Re: Fix locale/weight.h with GCC 3.5
Date: Wed, 08 Sep 2004 17:24:00 -0000	[thread overview]
Message-ID: <hor7pck72m.fsf@reger.suse.de> (raw)
In-Reply-To: <200409081701.i88H1lmf031187@magilla.sf.frob.com> (Roland McGrath's message of "Wed, 8 Sep 2004 10:01:47 -0700")

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

Roland McGrath <roland@redhat.com> writes:

>> -static inline void
>> +inline void
>> +__attribute ((always_inline))
>>  elf_machine_rela (struct link_map *map, const Elf64_Rela *reloc,
>>  		  const Elf64_Sym *sym, const struct r_found_version *version,
>>  		  void *const reloc_addr_arg)
>
> Does this really do the right thing in all of 3.[345]?
> I would think this would generate an external entry point too.

It seems so :-(

$ nm dl-conflict.os
                 U _dl_argv_internal
                 U _dl_dprintf
                 U _dl_reloc_bad_type
00000000000000a0 T _dl_resolve_conflicts
0000000000000000 t elf_machine_rela.0
                 U _GLOBAL_OFFSET_TABLE_
0000000000000017 r .LC0
0000000000000000 r .LC1
0000000000000000 r .LC2
                 U _rtld_local
                 U _rtld_local_ro

So, should I add #ifndef RESOLVE here also?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2004-09-08 17:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-06 18:52 Andreas Jaeger
2004-09-06 19:22 ` Andreas Jaeger
2004-09-06 21:21   ` Roland McGrath
2004-09-07  5:06     ` Andreas Jaeger
2004-09-07  8:02       ` Roland McGrath
2004-09-07 11:26         ` Andreas Jaeger
2004-09-07 18:09           ` Andreas Jaeger
2004-09-07 21:26             ` Roland McGrath
2004-09-08  4:57               ` Andreas Jaeger
2004-09-08  5:40                 ` Andreas Jaeger
2004-09-08 17:01                   ` Roland McGrath
2004-09-08 17:24                     ` Andreas Jaeger [this message]
2004-09-08 17:46                       ` Roland McGrath
2004-09-08 19:33                         ` Andreas Jaeger
2004-09-08 19:44                       ` Andreas Jaeger
2004-09-08 20:02                         ` Roland McGrath
2004-09-09  8:19                         ` Jakub Jelinek
2004-09-09  9:20                           ` Andreas Jaeger
2004-09-21  7:19                   ` Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hor7pck72m.fsf@reger.suse.de \
    --to=aj@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).