From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26046 invoked by alias); 10 Apr 2004 18:38:56 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 26025 invoked from network); 10 Apr 2004 18:38:55 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sources.redhat.com with SMTP; 10 Apr 2004 18:38:55 -0000 Received: from hermes.suse.de (Hermes.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id EF173431051; Sat, 10 Apr 2004 20:38:54 +0200 (CEST) To: Ulrich Drepper Cc: libc-hacker@sources.redhat.com Subject: Re: INTERNAL_SYSCALL and function calls in arguments References: <20040409071510.GA21965@suse.de> <407825B0.1010401@redhat.com> From: Andreas Schwab X-Yow: .. I wonder if I ought to tell them about my PREVIOUS LIFE as a COMPLETE STRANGER? Date: Sat, 10 Apr 2004 18:38:00 -0000 In-Reply-To: <407825B0.1010401@redhat.com> (Ulrich Drepper's message of "Sat, 10 Apr 2004 09:49:52 -0700") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-04/txt/msg00019.txt.bz2 Ulrich Drepper writes: > Andreas Schwab wrote: > >> Here is a patch to fix the INTERNAL_SYSCALL macro for x86_64 and ia64. >> The definition on arm is probably also affected, but I can't test it. > > How does the generated code for all cases but the problematic one look > like? If more code is generated the change is no good. Since the change only introduces temporary variables which the compiler would create internally anyway, the compiler is perfectly capable to optimize them away, and in all cases except sched_setaffinity the generated code is virtually identical. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."