From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-5600-listarch-libc-hacker=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 26789 invoked by alias); 23 Sep 2002 08:53:44 -0000
Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sources.redhat.com>
List-Help: <mailto:libc-hacker-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: libc-hacker-owner@sources.redhat.com
Received: (qmail 26772 invoked from network); 23 Sep 2002 08:53:41 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by sources.redhat.com with SMTP; 23 Sep 2002 08:53:42 -0000
Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201])
	by Cantor.suse.de (Postfix) with ESMTP
	id 4285814522; Mon, 23 Sep 2002 10:53:41 +0200 (MEST)
X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f
To: Roland McGrath <roland@redhat.com>
Cc: libc-hacker@sources.redhat.com
Subject: Re: test-src in elf/Makefile
References: <200209222048.g8MKm8n02937@magilla.sf.frob.com>
X-Yow: RELATIVES!!
From: Andreas Schwab <schwab@suse.de>
Date: Mon, 23 Sep 2002 01:53:00 -0000
In-Reply-To: <200209222048.g8MKm8n02937@magilla.sf.frob.com> (Roland
 McGrath's message of "Sun, 22 Sep 2002 13:48:08 -0700")
Message-ID: <jed6r584to.fsf@sykes.suse.de>
User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-SW-Source: 2002-09/txt/msg00058.txt.bz2

Roland McGrath <roland@redhat.com> writes:

|> > What is this supposed to fix:
|> > 
|> > 	* elf/Makefile (test-srcs): Add $(modules-names) to it.
|> > 
|> > test-srcs is supposed to only contain targets for binaries, but
|> > modules-names only contains .so targets.
|> 
|> This was the easy way to make sure that cppflags-iterator.mk got used for
|> compiling those modules, which should have -DNOT_IN_libc.  I now notice
|> that test-srcs is used for binaries-bounded, which is not appropriate for
|> these modules, but I am not sure it hurts.

It hurts when compiling with a cross compiler, see the tests target in
Rules:

ifeq ($(cross-compiling),yes)
tests: $(addprefix $(objpfx),$(tests) $(test-srcs))
xtests: tests
else

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."