public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: libc-hacker@sourceware.org
Subject: Fix version map sorting
Date: Thu, 22 Jan 2009 00:01:00 -0000	[thread overview]
Message-ID: <jeljt45hw4.fsf@sykes.suse.de> (raw)

The math/Versions file has an inline comment which is mishandled by the
version map scripts:

    exp2; exp2f; # exp2l; -- bug omitted this until GLIBC_2.4 (below)

Such inline comments are not stripped, and the dot in it becomes
significant when sorting the temporary versions file.  On targets where
GLIBC_2.2 is the earliest version for libm this causes the file to be
out of order: this line is sorted as if belonging to GLIBC_2.2.4.  Fixed
by putting the comment on a line by itself.

Andreas.

2009-01-22  Andreas Schwab  <schwab@suse.de>

	* math/Versions: Avoid inline comment.

--- math/Versions	29 Mär 2005 11:41:38 +0200	1.9
+++ math/Versions	22 Jan 2009 00:42:47 +0100	
@@ -94,7 +94,8 @@ libm {
   }
   GLIBC_2.1 {
     # mathematical functions
-    exp2; exp2f; # exp2l; -- bug omitted this until GLIBC_2.4 (below)
+    exp2; exp2f;
+    # exp2l; -- bug omitted this until GLIBC_2.4 (below)
     exp10; exp10f; exp10l;
     fdim; fdimf; fdiml;
     fma; fmaf; fmal;

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

             reply	other threads:[~2009-01-22  0:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-22  0:01 Andreas Schwab [this message]
2009-01-22  2:52 ` Roland McGrath
2009-01-22  9:47   ` Andreas Schwab
2009-01-22  9:49     ` Roland McGrath
2009-01-22 10:28       ` Andreas Schwab
2009-01-22 13:01         ` Andreas Schwab
2009-01-22 20:38           ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jeljt45hw4.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=libc-hacker@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).