From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29683 invoked by alias); 12 Aug 2004 16:46:29 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 29657 invoked from network); 12 Aug 2004 16:46:28 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 12 Aug 2004 16:46:28 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 6B133A4052C; Thu, 12 Aug 2004 18:44:40 +0200 (CEST) To: Roland McGrath Cc: libc-hacker@sources.redhat.com Subject: Re: Fix configure check for source locations References: <200408120614.i7C6E3oW028156@magilla.sf.frob.com> From: Andreas Schwab X-Yow: DIDI... is that a MARTIAN name, or, are we in ISRAEL? Date: Thu, 12 Aug 2004 16:46:00 -0000 In-Reply-To: <200408120614.i7C6E3oW028156@magilla.sf.frob.com> (Roland McGrath's message of "Wed, 11 Aug 2004 23:14:03 -0700") Message-ID: User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2004-08/txt/msg00045.txt.bz2 Roland McGrath writes: >> 2004-08-11 Andreas Schwab >> >> * configure.in: Fix libc_cv_cpp_asm_debuginfo test for ia64 and >> add missing parens. > > I put in the syntax fix. The outcome of this test is actually only used on > i?86 (in sysdeps/i386/sysdep.h). Unless an actual need for it is being > introduced, I would prefer, rather than kludging it up for general use, to > just stuff it into sysdeps/i386/configure.in instead so it won't even run > on ia64. So how about this: 2004-08-12 Andreas Schwab * configure.in (libc_cv_cpp_asm_debuginfo): Move check to ... * sysdeps/i386/configure.in: ... here. New file. * config.h.in (HAVE_CPP_ASM_DEBUGINFO): Mark it i386 specific. * configure: Rebuild. * sysdeps/i386/configure: New file. Index: config.h.in =================================================================== RCS file: /cvs/glibc/libc/config.h.in,v retrieving revision 1.68 diff -u -p -a -r1.68 config.h.in --- config.h.in 6 Jul 2004 04:14:17 -0000 1.68 +++ config.h.in 12 Aug 2004 16:32:27 -0000 @@ -61,9 +61,6 @@ /* Define a symbol_name as a global .symbol_name for ld. */ #undef HAVE_ASM_GLOBAL_DOT_NAME -/* Define if the assembler generates debugging information directly. */ -#undef HAVE_CPP_ASM_DEBUGINFO - /* Define if _Unwind_Find_FDE should be exported from glibc. */ #undef EXPORT_UNWIND_FIND_FDE @@ -199,6 +196,10 @@ /* Mach/i386 specific: define if the `i386_set_gdt' RPC is available. */ #undef HAVE_I386_SET_GDT +/* i386 specific: Define if the assembler generates debugging information + directly. */ +#undef HAVE_CPP_ASM_DEBUGINFO + /* Defined if forced unwind support is available. */ #undef HAVE_FORCED_UNWIND Index: configure.in =================================================================== RCS file: /cvs/glibc/libc/configure.in,v retrieving revision 1.420 diff -u -p -a -r1.420 configure.in --- configure.in 12 Aug 2004 06:12:22 -0000 1.420 +++ configure.in 12 Aug 2004 16:32:27 -0000 @@ -1656,39 +1656,6 @@ if test $libc_cv_asm_cfi_directives = ye AC_DEFINE(HAVE_ASM_CFI_DIRECTIVES) fi -AC_CACHE_CHECK(if -g produces usable source locations for assembler-with-cpp, - libc_cv_cpp_asm_debuginfo, [dnl -cat > conftest.S <&AS_MESSAGE_LOG_FD]) && { - ac_pattern='conftest\.S' - AC_TRY_COMMAND([readelf --debug-dump=line conftest.o | - grep $ac_pattern 1>&AS_MESSAGE_LOG_FD]) - }; then - libc_cv_cpp_asm_debuginfo=yes -else - libc_cv_cpp_asm_debuginfo=no -fi -rm -f conftest*])AC_SUBST(libc_cv_cpp_asm_debuginfo) -if test $libc_cv_cpp_asm_debuginfo = yes; then - AC_DEFINE(HAVE_CPP_ASM_DEBUGINFO) -fi - AC_CACHE_CHECK(for ld --no-whole-archive, libc_cv_ld_no_whole_archive, [dnl cat > conftest.c <<\EOF _start () {} Index: sysdeps/i386/configure.in =================================================================== RCS file: sysdeps/i386/configure.in diff -N sysdeps/i386/configure.in --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ sysdeps/i386/configure.in 12 Aug 2004 16:32:30 -0000 @@ -0,0 +1,33 @@ +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. +# Local configure fragment for sysdeps/i386. + +AC_CACHE_CHECK(if -g produces usable source locations for assembler-with-cpp, + libc_cv_cpp_asm_debuginfo, [dnl +cat > conftest.S <&AS_MESSAGE_LOG_FD]) && { + ac_pattern='conftest\.S' + AC_TRY_COMMAND([readelf --debug-dump=line conftest.o | + grep $ac_pattern 1>&AS_MESSAGE_LOG_FD]) + }; then + libc_cv_cpp_asm_debuginfo=yes +else + libc_cv_cpp_asm_debuginfo=no +fi +rm -f conftest*]) +AC_SUBST(libc_cv_cpp_asm_debuginfo) +if test $libc_cv_cpp_asm_debuginfo = yes; then + AC_DEFINE(HAVE_CPP_ASM_DEBUGINFO) +fi Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."