public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
	Roland McGrath <roland@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix i386 <bits/string.h>
Date: Sun, 13 Jun 2004 21:39:00 -0000	[thread overview]
Message-ID: <jept83p27b.fsf@sykes.suse.de> (raw)
In-Reply-To: <20040613173547.GR5191@sunsite.ms.mff.cuni.cz> (Jakub Jelinek's message of "Sun, 13 Jun 2004 19:35:47 +0200")

Jakub Jelinek <jakub@redhat.com> writes:

> --- libc/sysdeps/i386/bits/string.h.jj	2003-09-05 06:03:03.000000000 -0400
> +++ libc/sysdeps/i386/bits/string.h	2004-06-13 15:35:35.000000000 -0400
> @@ -43,8 +43,8 @@
>  #define _HAVE_STRING_ARCH_memcpy 1
>  #define memcpy(dest, src, n) \
>    (__extension__ (__builtin_constant_p (n)				      \
> -		  ? __memcpy_c (dest, src, n)				      \
> -		  : memcpy (dest, src, n)))
> +		  ? __memcpy_c ((dest), (src), (n))			      \
> +		  : memcpy ((dest), (src), (n))))

These parens are useless.  It is impossible to pass a comma inside a macro
argument without putting it in parens itself.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2004-06-13 21:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-13 19:50 Jakub Jelinek
2004-06-13 21:39 ` Andreas Schwab [this message]
2004-06-15 20:12 ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jept83p27b.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=drepper@redhat.com \
    --cc=jakub@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).