From: Andreas Schwab <schwab@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Roland McGrath <roland@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix futimesat with NULL second argument
Date: Thu, 24 Nov 2005 14:34:00 -0000 [thread overview]
Message-ID: <jezmnuf72i.fsf@sykes.suse.de> (raw)
In-Reply-To: <20051118210957.GO16723@sunsite.mff.cuni.cz> (Jakub Jelinek's message of "Fri, 18 Nov 2005 22:09:58 +0100")
Jakub Jelinek <jakub@redhat.com> writes:
> According to http://docs.sun.com/app/docs/doc/816-5167/6mbb2jam2?a=view
> futimesat (fd, NULL, tvp)
> is supposed to set times on the file referenced by fd.
>
> touch from coreutils uses this, so with current CVS glibc crashes
> (see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=173581).
It still crashes.
Andreas.
2005-11-24 Andreas Schwab <schwab@suse.de>
* time/sys/time.h: Remove nonnull attribute from futimesat.
--- time/sys/time.h.~1.36.~ 2005-11-13 22:35:20.000000000 +0100
+++ time/sys/time.h 2005-11-24 15:29:18.000000000 +0100
@@ -153,7 +153,7 @@ extern int futimes (int __fd, __const st
modification time of FILE to TVP[1]. If TVP is a null pointer, use
the current time instead. Returns 0 on success, -1 on errors. */
extern int futimesat (int __fd, __const char *__file,
- __const struct timeval __tvp[2]) __THROW __nonnull ((2));
+ __const struct timeval __tvp[2]) __THROW;
#endif
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2005-11-24 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 21:10 Jakub Jelinek
2005-11-18 22:15 ` Jakub Jelinek
2005-11-19 17:19 ` Ulrich Drepper
2005-11-24 14:34 ` Andreas Schwab [this message]
2005-11-24 18:09 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jezmnuf72i.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).