From: Andreas Schwab <schwab@linux-m68k.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix strstr/strcasestr/fma/fmaf on x86_64
Date: Wed, 02 Sep 2009 10:08:00 -0000 [thread overview]
Message-ID: <m31vmpd5gg.fsf@hase.home> (raw)
In-Reply-To: <20090902085848.GC3611@sunsite.ms.mff.cuni.cz> (Jakub Jelinek's message of "Wed, 2 Sep 2009 10:58:48 +0200")
Jakub Jelinek <jakub@redhat.com> writes:
> --- libc/sysdeps/x86_64/multiarch/strstr-c.c.jj 2009-07-23 08:59:29.000000000 +0200
> +++ libc/sysdeps/x86_64/multiarch/strstr-c.c 2009-09-02 10:34:48.000000000 +0200
> @@ -7,6 +7,7 @@
>
> #include "string/strstr.c"
>
> -extern char *__strstr_sse42 (const char *, const char *);
> +extern char *__strstr_sse42 (const char *, const char *) attribute_hidden;
> +extern __typeof (__strstr_sse2) __strstr_sse2 attribute_hidden;
Shouldn't those use the libc_hidden* macros?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2009-09-02 10:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 9:32 Jakub Jelinek
2009-09-02 10:08 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vmpd5gg.fsf@hase.home \
--to=schwab@linux-m68k.org \
--cc=drepper@redhat.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).