From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-9534-listarch-libc-hacker=sources.redhat.com@sourceware.org>
Received: (qmail 16795 invoked by alias); 2 Sep 2009 10:08:44 -0000
Received: (qmail 16779 invoked by uid 22791); 2 Sep 2009 10:08:44 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0
	tests=AWL,BAYES_00,SARE_SUB_6CONS_WORD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1-old.redhat.com (HELO mx1.redhat.com) (66.187.233.31)
    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Sep 2009 10:08:37 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com ([10.11.47.254])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n82A8Yvp015301
	for <libc-hacker@sources.redhat.com>; Wed, 2 Sep 2009 06:08:34 -0400
Received: from hase.home (vpn-10-100.str.redhat.com [10.32.10.100])
	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n82A8VXL010913;
	Wed, 2 Sep 2009 06:08:32 -0400
From: Andreas Schwab <schwab@linux-m68k.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Ulrich Drepper <drepper@redhat.com>,
        Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix strstr/strcasestr/fma/fmaf on x86_64
References: <20090902085848.GC3611@sunsite.ms.mff.cuni.cz>
X-Yow: Why are these athletic shoe salesmen following me??
Date: Wed, 02 Sep 2009 10:08:00 -0000
In-Reply-To: <20090902085848.GC3611@sunsite.ms.mff.cuni.cz> (Jakub Jelinek's
	message of "Wed, 2 Sep 2009 10:58:48 +0200")
Message-ID: <m31vmpd5gg.fsf@hase.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-hacker.sourceware.org>
List-Subscribe: <mailto:libc-hacker-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sourceware.org>
List-Help: <mailto:libc-hacker-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-hacker-owner@sourceware.org
X-SW-Source: 2009-09/txt/msg00002.txt.bz2

Jakub Jelinek <jakub@redhat.com> writes:

> --- libc/sysdeps/x86_64/multiarch/strstr-c.c.jj	2009-07-23 08:59:29.000000000 +0200
> +++ libc/sysdeps/x86_64/multiarch/strstr-c.c	2009-09-02 10:34:48.000000000 +0200
> @@ -7,6 +7,7 @@
>  
>  #include "string/strstr.c"
>  
> -extern char *__strstr_sse42 (const char *, const char *);
> +extern char *__strstr_sse42 (const char *, const char *) attribute_hidden;
> +extern __typeof (__strstr_sse2) __strstr_sse2 attribute_hidden;

Shouldn't those use the libc_hidden* macros?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."