public inbox for
 help / color / mirror / Atom feed
From: Andreas Jaeger <>
To: GNU libc hackers <>
Subject: Fix error.h problems
Date: Sun, 07 Oct 2007 14:47:00 -0000	[thread overview]
Message-ID: <m37ilzoubk.fsf@gromit.moeb> (raw)

[-- Attachment #1: Type: text/plain, Size: 2296 bytes --]

Current cvs fails to build for me with:
In file included from error.h:53,
                 from error.c:39:
./bits/error.h:65: error: conflicting types for ‘error_at_line’
error.h:37: error: previous declaration of ‘error_at_line’ was here
./bits/error.h: In function ‘error_at_line’:
./bits/error.h:67: error: ‘__fname’ undeclared (first use in this function)
./bits/error.h:67: error: (Each undeclared identifier is reported only once
./bits/error.h:67: error: for each function it appears in.)
./bits/error.h:67: error: ‘__line’ undeclared (first use in this function)
make[2]: *** [/builds/glibc/4.3-nptl/misc/error.o] Error 1

Fixed by the appended patch.

Another error later on:
In file included from ../include/error.h:1,
                 from cache.c:20:
../misc/error.h:53:25: error: bits/error.h: No such file or directory
make[2]: *** [/builds/glibc/4.3-nptl/elf/cache.o] Error 1

fixed with creation of include/bits/error.h

Ok to commit these?


2007-10-07  Andreas Jaeger  <>

	* include/bits/error.h: New file.

	* misc/bits/error.h (error_at_line): Fix prototype.

Index: include/bits/error.h
--- include/bits/error.h	created
+++ include/bits/error.h	2007-10-07 16:30:24.000000000 +0200	1.1
@@ -0,0 +1 @@
+#include "../../misc/bits/error.h"

Index: misc/bits/error.h
--- bits/error.h	4 Oct 2007 18:01:24 -0000	1.2
+++ bits/error.h	7 Oct 2007 14:04:20 -0000
@@ -61,7 +61,8 @@ extern void __REDIRECT (__error_at_line_
 /* If we know the function will never return make sure the compiler
    realizes that, too.  */
 __extern_always_inline void
-error_at_line (int __status, int __errnum, const char *__format, ...)
+error_at_line (int __status, int __errnum, const char *__fname, 
+	       unsigned int __line, const char *__format, ...)
   if (__builtin_constant_p (__status) && __status != 0)
     __error_at_line_noreturn (__status, __errnum, __fname, __line, __format,

 Andreas Jaeger, Director Platform/openSUSE,
  SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
   Maxfeldstr. 5, 90409 Nürnberg, Germany
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

             reply	other threads:[~2007-10-07 14:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-07 14:47 Andreas Jaeger [this message]
2007-10-07 17:30 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37ilzoubk.fsf@gromit.moeb \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).