From: Andreas Jaeger <aj@suse.de>
To: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Use tmpfile instead of tmpnam
Date: Mon, 22 Mar 2004 09:04:00 -0000 [thread overview]
Message-ID: <m37jxe4qsr.fsf@gromit.moeb> (raw)
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
This is some cosmetic to avoid getting a warning about dangerous use
of tmpnam...
Ok to commit?
Andreas
2004-03-21 Andreas Jaeger <aj@suse.de>
* misc/tst-mntent.c (main): Use tmpfile instead of tmpnam.
============================================================
Index: misc/tst-mntent.c
--- misc/tst-mntent.c 26 Jul 1999 01:45:55 -0000 1.3
+++ misc/tst-mntent.c 21 Mar 2004 06:43:07 -0000
@@ -11,7 +11,6 @@ main (int argc, char *argv[])
int result = 0;
struct mntent mef;
struct mntent *mnt = &mef;
- char *name;
FILE *fp;
mef.mnt_fsname = strdupa ("/dev/hda1");
@@ -29,8 +28,7 @@ main (int argc, char *argv[])
result = 1;
}
- name = tmpnam (NULL);
- fp = fopen (name, "w+");
+ fp = tmpfile ();
if (fp == NULL)
{
printf ("Cannot open temporary file: %m\n");
@@ -75,8 +73,6 @@ main (int argc, char *argv[])
puts ("Error while reading written entry back in");
result = 1;
}
-
- remove (name);
}
return result;
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
next reply other threads:[~2004-03-21 7:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 9:04 Andreas Jaeger [this message]
2004-03-22 18:11 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37jxe4qsr.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).