From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31791 invoked by alias); 8 Feb 2004 18:26:40 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 31774 invoked from network); 8 Feb 2004 18:26:40 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sources.redhat.com with SMTP; 8 Feb 2004 18:26:40 -0000 Received: from hermes.suse.de (Hermes.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id A4A6B17CEF3; Sun, 8 Feb 2004 19:26:39 +0100 (CET) Received: from aj by arthur.inka.de with local (Exim 4.22) id 1Aptdd-0002CM-D5; Sun, 08 Feb 2004 19:26:37 +0100 To: Ulrich Drepper Cc: Andreas Schwab , libc-hacker@sources.redhat.com Subject: Re: Fix cast as lvalue in sunrpc References: <40267CA7.4050506@redhat.com> From: Andreas Jaeger Date: Sun, 08 Feb 2004 18:26:00 -0000 In-Reply-To: <40267CA7.4050506@redhat.com> (Ulrich Drepper's message of "Sun, 08 Feb 2004 10:15:03 -0800") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Rational FORTRAN, linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2004-02/txt/msg00007.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1223 Ulrich Drepper writes: > Andreas Schwab wrote: >> This fixes the uses of casts as lvalue in the sunrpc code. > > Does this change the generated code? Not with gcc-3_3-hammer-branch on AMD64: gromit:/builds/glibc/hammer:[130]$ ll sunrpc/clnt_perr.o -rw-r--r-- 1 aj users 116248 Feb 8 19:25 sunrpc/clnt_perr.o gromit:/builds/glibc/hammer:[0]$ ll sunrpc/clnt_perr.o /tmp/clnt_perr.o=20 -rw-r--r-- 1 aj users 116248 Feb 8 19:24 /tmp/clnt_perr.o -rw-r--r-- 1 aj users 116248 Feb 8 19:25 sunrpc/clnt_perr.o gromit:/builds/glibc/hammer:[0]$ objdump -d sunrpc/clnt_perr.o > /tmp/1 gromit:/builds/glibc/hammer:[0]$ objdump -d /tmp/clnt_perr.o > /tmp/2 gromit:/builds/glibc/hammer:[0]$ diff -u /tmp/1 /tmp/2 --- /tmp/1 2004-02-08 19:25:33.000000000 +0100 +++ /tmp/2 2004-02-08 19:25:40.000000000 +0100 @@ -1,5 +1,5 @@ =20 -sunrpc/clnt_perr.o: file format elf64-x86-64 +/tmp/clnt_perr.o: file format elf64-x86-64 =20 Disassembly of section .text: Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SuSE Linux AG, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQBAJn9dOJpWPMJyoSYRAm7pAJ4pRs26/yiJDcWrQF4ltpKBTyNnlwCeIRPB wfjb0xLz9W4qrwsJ4HuuuaY= =1w8K -----END PGP SIGNATURE----- --=-=-=--