public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Remove obsolete function keyword
@ 2011-05-30 14:39 Andreas Schwab
  2011-05-30 15:54 ` Ulrich Drepper
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2011-05-30 14:39 UTC (permalink / raw)
  To: libc-hacker

2011-05-30  Andreas Schwab  <schwab@redhat.com>

	* elf/sotruss.ksh: Remove obsolete function keyword.
---
 elf/sotruss.ksh |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/elf/sotruss.ksh b/elf/sotruss.ksh
index 6bbdc89..fe2ec05 100755
--- a/elf/sotruss.ksh
+++ b/elf/sotruss.ksh
@@ -29,7 +29,7 @@ unset SOTRUSS_NOINDENT
 SOTRUSS_WHICH=$$
 lib='@PREFIX@/$LIB/audit/sotruss-lib.so'
 
-function do_help {
+do_help () {
   echo $"Usage: sotruss [OPTION...] [--] EXECUTABLE [EXECUTABLE-OPTION...]
   -F, --from FROMLIST     trace calls from objects on FORMLIST
   -T, --to TOLIST         trace calls to objects on TOLIST
@@ -52,13 +52,13 @@ function do_help {
   exit 0
 }
 
-function do_missing_arg {
+do_missing_arg () {
   printf >&2 $"%s: option requires an argument -- '%s'\n" sotruss "$1"
   printf >&2 $"Try \`%s --help' or \`%s --usage' for more information.\n" sotruss sotruss
   exit 1
 }
 
-function do_ambiguous {
+do_ambiguous () {
   printf >&2 $"%s: option is ambiguous; possibilities:"
   while test $# -gt 0; do
     printf >&2 " '%s'" $1
-- 
1.7.4.4


-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Remove obsolete function keyword
  2011-05-30 14:39 [PATCH] Remove obsolete function keyword Andreas Schwab
@ 2011-05-30 15:54 ` Ulrich Drepper
  2011-05-30 16:53   ` Andreas Schwab
  0 siblings, 1 reply; 4+ messages in thread
From: Ulrich Drepper @ 2011-05-30 15:54 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

On Mon, May 30, 2011 at 10:39, Andreas Schwab <schwab@redhat.com> wrote:
> 2011-05-30  Andreas Schwab  <schwab@redhat.com>
>
>        * elf/sotruss.ksh: Remove obsolete function keyword.

Why?  You have to stop sending patches without explanations.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Remove obsolete function keyword
  2011-05-30 15:54 ` Ulrich Drepper
@ 2011-05-30 16:53   ` Andreas Schwab
  2011-05-30 17:02     ` Ulrich Drepper
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2011-05-30 16:53 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: libc-hacker

Because it is obsolete.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Remove obsolete function keyword
  2011-05-30 16:53   ` Andreas Schwab
@ 2011-05-30 17:02     ` Ulrich Drepper
  0 siblings, 0 replies; 4+ messages in thread
From: Ulrich Drepper @ 2011-05-30 17:02 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: libc-hacker

On Mon, May 30, 2011 at 12:52, Andreas Schwab <schwab@redhat.com> wrote:
> Because it is obsolete.

Its; extra syntax which bash and ksh accept and which helps
understanding the code.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-05-30 17:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-30 14:39 [PATCH] Remove obsolete function keyword Andreas Schwab
2011-05-30 15:54 ` Ulrich Drepper
2011-05-30 16:53   ` Andreas Schwab
2011-05-30 17:02     ` Ulrich Drepper

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).