From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26924 invoked by alias); 7 Jan 2005 13:58:31 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 26899 invoked from network); 7 Jan 2005 13:58:29 -0000 Received: from unknown (HELO Cantor.suse.de) (195.135.220.2) by sourceware.org with SMTP; 7 Jan 2005 13:58:29 -0000 Received: from hermes.suse.de (hermes-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by Cantor.suse.de (Postfix) with ESMTP id 6F3F112F592C; Fri, 7 Jan 2005 14:58:29 +0100 (CET) Received: from aj by arthur.inka.de with local (Exim 4.42) id 1CmudD-0005E6-DE; Fri, 07 Jan 2005 14:58:23 +0100 From: Andreas Jaeger To: Jakub Jelinek Cc: Glibc hackers Subject: Re: Fixes for make clean References: <20050107124425.GB17169@sunsite.mff.cuni.cz> Date: Fri, 07 Jan 2005 13:58:00 -0000 In-Reply-To: <20050107124425.GB17169@sunsite.mff.cuni.cz> (Jakub Jelinek's message of "Fri, 7 Jan 2005 13:44:25 +0100") Message-ID: User-Agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.4 (Security Through Obscurity, linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2005-01/txt/msg00004.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1861 Jakub Jelinek writes: > On Mon, Jan 03, 2005 at 12:10:58PM +0100, Andreas Jaeger wrote: >> 2005-01-03 Andreas Jaeger >>=20 >> * elf/Makefile (tests): Change rule for tst-pie1 so that make >> clean works. >>=20 >> --- elf/Makefile 27 Oct 2004 20:26:47 -0000 1.287 >> +++ elf/Makefile 3 Jan 2005 11:10:36 -0000 >> @@ -1,4 +1,4 @@ >> -# Copyright (C) 1995-2002, 2003, 2004 Free Software Foundation, Inc. >> +# Copyright (C) 1995-2004, 2005 Free Software Foundation, Inc. >> # This file is part of the GNU C Library. >>=20=20 >> # The GNU C Library is free software; you can redistribute it and/or >> @@ -163,7 +163,7 @@ tests-nodlopen-yes =3D nodlopen nodlopen2 >> tests-execstack-yes =3D tst-execstack tst-execstack-needed tst-execstac= k-prog >> endif >> ifeq (yesyes,$(have-fpie)$(build-shared)) >> -tests: $(objpfx)tst-pie1.out >> +tests +=3D tst-pie1 >> endif >> modules-names =3D testobj1 testobj2 testobj3 testobj4 testobj5 testobj6= \ >> testobj1_1 failobj constload2 constload3 unloadmod \ > > This change is bad: > make[2]: Entering directory > `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: = warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/g= libc-20050106T2203/build-i686-linux/elf/tst-pie1' > ../Rules:118: warning: ignoring old commands for target `/usr/src/build/5= 02950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1' > mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-lin= ux/elf > > I think putting tst-pie1.out and tst-pie1 into generated instead would cu= re > this. I'll revert my patch now, Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQBB3pV/OJpWPMJyoSYRAlPXAJ9Cov/HaiK3GXcND4HukMYXiAtrXwCeJUtB ARLYfIWD8dDu4P8exoZlfB8= =M/RU -----END PGP SIGNATURE----- --=-=-=--