From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26313 invoked by alias); 15 Jan 2006 17:44:05 -0000 Received: (qmail 26296 invoked by uid 22791); 15 Jan 2006 17:44:05 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 15 Jan 2006 17:44:01 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 131FE7AF; Sun, 15 Jan 2006 18:43:59 +0100 (CET) Received: from aj by arthur.inka.de with local (Exim 4.51) id 1EyBv3-0003S1-71; Sun, 15 Jan 2006 18:43:57 +0100 From: Andreas Jaeger To: Ulrich Drepper Cc: Glibc hackers Subject: Re: [BZ #2078, 2079] Fix some wide functions References: <43CA894B.7000903@redhat.com> OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Sun, 15 Jan 2006 17:44:00 -0000 In-Reply-To: <43CA894B.7000903@redhat.com> (Ulrich Drepper's message of "Sun, 15 Jan 2006 09:41:31 -0800") Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00072.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1186 Ulrich Drepper writes: > Andreas Jaeger wrote: >> Index: libio/wfileops.c >> --- libio/wfileops.c 14 Jan 2004 18:40:03 -0000 1.29 >> +++ libio/wfileops.c 15 Jan 2006 16:08:16 -0000 >> @@ -1,4 +1,4 @@ >> -/* Copyright (C) 1993,1995,1997-2003,2004 Free Software Foundation, Inc. >> +/* Copyright (C) 1993,1995,1997-2003,2004, 2006 Free Software Foundatio= n, Inc. >> This file is part of the GNU C Library. >> Written by Ulrich Drepper . >> Based on the single byte version by Per Bothner . >> @@ -69,7 +69,7 @@ _IO_wdo_write (fp, data, to_do) >> { >> if (_IO_new_do_write (fp, fp->_IO_write_base, >> fp->_IO_write_ptr - fp->_IO_write_base) =3D=3D EOF) >> - return EOF; >> + return WEOF; > > As far as fixing this specific kind of mistake, the patch is fine. But > there is something fishy in the use of _IO_wdo_write. Will you take care of this, please? I'll commit my patch now, Andreas --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj/ SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBDyondOJpWPMJyoSYRAthWAJ9LLMOWYxqxB833OteCpcJsxNPHyACfdTdo BdUDDmSvybwr2C+a4LAfdKw= =2oFt -----END PGP SIGNATURE----- --=-=-=--