From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22895 invoked by alias); 9 Oct 2007 05:50:53 -0000 Received: (qmail 22878 invoked by uid 22791); 9 Oct 2007 05:50:51 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 09 Oct 2007 05:50:45 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 3B3AB22DDA; Tue, 9 Oct 2007 07:50:43 +0200 (CEST) Received: from aj by arthur.inka.de with local (Exim 4.63) (envelope-from ) id 1If7zN-00088w-7s; Tue, 09 Oct 2007 07:50:41 +0200 From: Andreas Jaeger To: Roland McGrath Cc: GNU libc hackers Subject: Re: Testsuite failure in check-localplt References: <20071008211011.C1E9E4D04CC@magilla.localdomain> OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Tue, 09 Oct 2007 05:50:00 -0000 In-Reply-To: <20071008211011.C1E9E4D04CC@magilla.localdomain> (sfid-20071009_033107_818411_8F2DB6935CE44DBB) (Roland McGrath's message of "Mon, 8 Oct 2007 14:10:11 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00009.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 957 Roland McGrath writes: > Look for the relocs in libc.so that refer to those symbols. Probably they > should be calling __read, which already has libc_hidden_proto. If they a= re > in code never reached by ISO C-only, then they could legitimately stick to > read for aesthetic purposes if one really cared, but then you'd need to a= dd > libc_hidden_proto for read in include/unistd.h, which we haven't needed y= et. > (If they are in low-level linux-specific code, they might want to be using > INLINE_SYSCALL anyway.) Thanks - that helped. It was in eventfd_read and write - and I just noticed that Uli already committed the obvious fix. The testsuite passes now for me, Andreas --=20 Andreas Jaeger, Director Platform/openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFHCxawOJpWPMJyoSYRAkRRAJ91YslRLLT07GSDnLPcD9nrrYAzQACfdv2V /2F/HtFXkW0S7Ix1rZ61pa0= =vYyR -----END PGP SIGNATURE----- --=-=-=--