From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13302 invoked by alias); 10 Jan 2006 19:32:46 -0000 Received: (qmail 13224 invoked by uid 22791); 10 Jan 2006 19:32:46 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jan 2006 19:32:43 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 8E8371D0CB for ; Tue, 10 Jan 2006 20:32:40 +0100 (CET) Received: from aj by arthur.inka.de with local (Exim 4.51) id 1EwPEU-0007gj-4u for libc-hacker@sources.redhat.com; Tue, 10 Jan 2006 20:32:38 +0100 From: Andreas Jaeger To: Glibc hackers Subject: error in include/time.h OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Tue, 10 Jan 2006 19:32:00 -0000 Message-ID: User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00048.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2867 I now get: gcc tst-initializers1-c89.c -c -std=3Dgnu99 -O2 -Wall -Winline -Wwrite-stri= ngs -fmerge-all-constants -g -Wstrict-prototypes -W -Wall -Werror -std=3D= c89 -I../include -I/builds/glibc/10.0-nptl/nptl -I/builds/glibc/10.0-nptl= -I../sysdeps/x86_64/elf -I../nptl/sysdeps/unix/sysv/linux/x86_64 -I../sysd= eps/unix/sysv/linux/x86_64 -I../sysdeps/unix/sysv/linux/wordsize-64 -I../np= tl/sysdeps/unix/sysv/linux -I../nptl/sysdeps/pthread -I../sysdeps/pthread -= I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common -I../= sysdeps/unix/mman -I../sysdeps/unix/inet -I../nptl/sysdeps/unix/sysv -I../s= ysdeps/unix/sysv -I../sysdeps/unix/x86_64 -I../nptl/sysdeps/unix -I../libid= n/sysdeps/unix -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/x86_64/fpu= -I../nptl/sysdeps/x86_64 -I../sysdeps/x86_64 -I../sysdeps/wordsize-64 -I..= /sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/f= lt-32 -I../nptl/sysdeps/generic -I../sysdeps/ieee754 -I../sysdeps/generic/e= lf -I../sysdeps/generic -I.. -I../libio -I. -D_LIBC_REENTRANT -include ..= /include/libc-symbols.h -DNOT_IN_libc=3D1 -o /builds/glibc/10.0-nptl/n= ptl/tst-initializers1-c89.o -MD -MP -MF /builds/glibc/10.0-nptl/nptl/tst-in= itializers1-c89.o.dt -MT /builds/glibc/10.0-nptl/nptl/tst-initializers1-c89= .o In file included from ../nptl/sysdeps/pthread/pthread.h:24, from ../include/pthread.h:1, from tst-initializers1.c:20, from tst-initializers1-c89.c:1: ../include/time.h:95: error: syntax error before =E2=80=98/=E2=80=99 token In file included from ../nptl/sysdeps/pthread/pthread.h:24, from ../include/pthread.h:1, from tst-initializers1.c:20, from tst-initializers1-c89.c:1: ../include/time.h:95:31: error: multi-character character constant Here's a patch. Ok to commit? Andreas 2006-01-10 Andreas Jaeger * include/time.h: Use normal comments. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Index: include/time.h --- include/time.h 23 Dec 2005 01:51:08 -0000 1.26 +++ include/time.h 10 Jan 2006 19:00:44 -0000 @@ -92,7 +92,7 @@ extern int __getclktck (void); /* strptime support. */ /* Status of lookup: do we use the locale data or the raw data? */ #ifndef __cplusplus -// C++ cannot deal with using 'not'. +/* C++ cannot deal with using 'not'. */ enum ptime_locale_status { not, loc, raw }; =20 extern char * __strptime_internal (const char *rp, const char *fmt, --=20 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iD8DBQBDxAvWOJpWPMJyoSYRAijaAJ9x9LIa3AbiVgXUVRmLyJziL+7hAACfVqUT lvIS7m/u1shcTki1wkLtXvI= =t57q -----END PGP SIGNATURE----- --=-=-=--