From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14523 invoked by alias); 10 Jun 2011 09:25:23 -0000 Received: (qmail 14506 invoked by uid 22791); 10 Jun 2011 09:25:22 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 09:25:06 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5A9P5u7009069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 Jun 2011 05:25:05 -0400 Received: from hase (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5A9P3Wb027050 for ; Fri, 10 Jun 2011 05:25:04 -0400 From: Andreas Schwab To: libc-hacker@sourceware.org Subject: [PATCH] Fix memory leak in getaddrinfo X-Yow: Nice decor! Date: Fri, 10 Jun 2011 09:25:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00000.txt.bz2 2011-06-10 Andreas Schwab * sysdeps/posix/getaddrinfo.c (gaih_inet): Fix logic allocating tmpbuf. --- sysdeps/posix/getaddrinfo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c index 1e017b2..469abe2 100644 --- a/sysdeps/posix/getaddrinfo.c +++ b/sysdeps/posix/getaddrinfo.c @@ -821,7 +821,7 @@ gaih_inet (const char *name, const struct gaih_service *service, size_t tmpbuflen = 1024; malloc_tmpbuf = !__libc_use_alloca (alloca_used + tmpbuflen); assert (tmpbuf == NULL); - if (malloc_tmpbuf) + if (!malloc_tmpbuf) tmpbuf = alloca_account (tmpbuflen, alloca_used); else { -- 1.7.4.4 -- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."