From: Andreas Jaeger <aj@suse.de>
To: GNU libc hackers <libc-hacker@sources.redhat.com>
Subject: Fix signalfd_siginfo on 32-bit
Date: Fri, 11 Jan 2008 10:02:00 -0000 [thread overview]
Message-ID: <m3prw8smt2.fsf@gromit.moeb> (raw)
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
Bug 5600 states that on 32-bit struct signalfd_siginfo is wrong. The
resolution is wrong IMO but I agree that we have a problem:
The linux kernel header has:
__u64 ssi_ptr;
while glibc uses
uintptr_t ssi_ptr;
This should result on 32-bit in differences for the following members
and for the size of the structure.
I suggest the following patch. Ok to commit?
Andreas
2008-01-11 Andreas Jaeger <aj@suse.de>
[BZ #5600]
* sysdeps/unix/sysv/linux/sys/signalfd.h (struct
signalfd_siginfo): Use 64-bit type for ssi_ptr to sync with Linux
kernel header.
============================================================
Index: sysdeps/unix/sysv/linux/sys/signalfd.h
--- sysdeps/unix/sysv/linux/sys/signalfd.h 3 Dec 2007 06:16:54 -0000 1.3
+++ sysdeps/unix/sysv/linux/sys/signalfd.h 11 Jan 2008 10:01:03 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 2007 Free Software Foundation, Inc.
+/* Copyright (C) 2007, 2008 Free Software Foundation, Inc.
This file is part of the GNU C Library.
The GNU C Library is free software; you can redistribute it and/or
@@ -38,7 +38,7 @@ struct signalfd_siginfo
uint32_t ssi_trapno;
int32_t ssi_status;
int32_t ssi_int;
- uintptr_t ssi_ptr;
+ uint64_t ssi_ptr;
uint64_t ssi_utime;
uint64_t ssi_stime;
uint64_t ssi_addr;
--
Andreas Jaeger, Director Platform/openSUSE, aj@suse.de
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
next reply other threads:[~2008-01-11 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 10:02 Andreas Jaeger [this message]
2008-01-11 20:30 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3prw8smt2.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).