From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25315 invoked by alias); 11 Jan 2008 10:02:19 -0000 Received: (qmail 25298 invoked by uid 22791); 11 Jan 2008 10:02:19 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 11 Jan 2008 10:01:54 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id B90532614C for ; Fri, 11 Jan 2008 11:01:51 +0100 (CET) Received: from aj by arthur.inka.de with local (Exim 4.63) (envelope-from ) id 1JDGhz-0005k5-0c for libc-hacker@sources.redhat.com; Fri, 11 Jan 2008 11:01:51 +0100 From: Andreas Jaeger To: GNU libc hackers Subject: Fix signalfd_siginfo on 32-bit OpenPGP: id=C272A126; url=http://www.suse.de/~aj/keys.txt Date: Fri, 11 Jan 2008 10:02:00 -0000 Message-ID: User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2008-01/txt/msg00002.txt.bz2 --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1668 Bug 5600 states that on 32-bit struct signalfd_siginfo is wrong. The resolution is wrong IMO but I agree that we have a problem: The linux kernel header has: __u64 ssi_ptr; while glibc uses uintptr_t ssi_ptr; This should result on 32-bit in differences for the following members and for the size of the structure. I suggest the following patch. Ok to commit? Andreas 2008-01-11 Andreas Jaeger [BZ #5600] * sysdeps/unix/sysv/linux/sys/signalfd.h (struct signalfd_siginfo): Use 64-bit type for ssi_ptr to sync with Linux kernel header. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Index: sysdeps/unix/sysv/linux/sys/signalfd.h --- sysdeps/unix/sysv/linux/sys/signalfd.h 3 Dec 2007 06:16:54 -0000 1.3 +++ sysdeps/unix/sysv/linux/sys/signalfd.h 11 Jan 2008 10:01:03 -0000 @@ -1,4 +1,4 @@ -/* Copyright (C) 2007 Free Software Foundation, Inc. +/* Copyright (C) 2007, 2008 Free Software Foundation, Inc. This file is part of the GNU C Library. =20 The GNU C Library is free software; you can redistribute it and/or @@ -38,7 +38,7 @@ struct signalfd_siginfo uint32_t ssi_trapno; int32_t ssi_status; int32_t ssi_int; - uintptr_t ssi_ptr; + uint64_t ssi_ptr; uint64_t ssi_utime; uint64_t ssi_stime; uint64_t ssi_addr; --=20 Andreas Jaeger, Director Platform/openSUSE, aj@suse.de SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --=-=-= Content-Type: application/pgp-signature Content-length: 188 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFHhz6MOJpWPMJyoSYRAhmAAJ0X3Ss1LuO2PkW/t8j8/JNa01xRLwCfWwdp CA9YlvBKvrKtUKgRX+Bfelo= =UeyP -----END PGP SIGNATURE----- --=-=-=--