From: Andreas Jaeger <aj@suse.de>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-hacker@sources.redhat.com
Subject: Re: INTERNAL_SYSCALL and function calls in arguments
Date: Sat, 10 Apr 2004 07:34:00 -0000 [thread overview]
Message-ID: <m3r7uwmglq.fsf@gromit.moeb> (raw)
In-Reply-To: <jeisg9b6z7.fsf@sykes.suse.de> (Andreas Schwab's message of "Fri, 09 Apr 2004 15:45:16 +0200")
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
Andreas Schwab <schwab@suse.de> writes:
> Thorsten Kukuk <kukuk@suse.de> writes:
>
>> Hi,
>>
>> sched_setaffinity has the following code:
>>
>> INTERNAL_SYSCALL (sched_getaffinity, err, 3, getpid(), psize, p)
>
> Here is a patch to fix the INTERNAL_SYSCALL macro for x86_64 and ia64.
> The definition on arm is probably also affected, but I can't test it.
The x86-64 version is ok. The question is just whether we want to go
this road - or fix sched_getaffinity instead. I consider it safer to
change INTERNAL_SYSCALL.
But we should check all other platforms, a brief look shows:
- m68k, x86 are ok
- x86-64, ia64: Fixed with your patch
- arm: Might need changes
- s390, s390x: Look also broken.
- ppc,ppc64, sparc, alpha, sh, mips, hppa, : Might need changes
Andreas
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
next prev parent reply other threads:[~2004-04-10 7:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-09 7:15 Thorsten Kukuk
2004-04-09 13:45 ` Andreas Schwab
2004-04-10 7:34 ` Andreas Jaeger [this message]
2004-04-13 12:54 ` Kaz Kojima
2004-04-16 19:07 ` Ulrich Drepper
2004-04-10 16:50 ` Ulrich Drepper
2004-04-10 18:38 ` Andreas Schwab
2004-04-10 19:11 ` Ulrich Drepper
2004-04-10 22:04 ` Andreas Schwab
2004-04-13 0:28 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r7uwmglq.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).