public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@redhat.com>
To: libc-hacker@sourceware.org
Subject: [PATCH] Fix crash in nscd GETAI call
Date: Fri, 09 Apr 2010 15:26:00 -0000	[thread overview]
Message-ID: <m3sk74lk9w.fsf@hase.home> (raw)

Testcase: getent ahosts irc.freenode.net

Andreas.

2010-04-09  Andreas Schwab  <schwab@redhat.com>

	* nscd/aicache.c (addhstaiX): Don't crash on missing canonical
	name.

---
 nscd/aicache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nscd/aicache.c b/nscd/aicache.c
index 992357d..1b3a7ee 100644
--- a/nscd/aicache.c
+++ b/nscd/aicache.c
@@ -166,7 +166,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req,
 		addrslen += IN6ADDRSZ;
 	    }
 	  canon = at->name;
-	  canonlen = strlen (canon) + 1;
+	  canonlen = canon == NULL ? 0 : strlen (canon) + 1;
 
 	  total = sizeof (*dataset) + naddrs + addrslen + canonlen;
 
-- 
1.7.0.1


-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

             reply	other threads:[~2010-04-09 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 15:26 Andreas Schwab [this message]
2010-04-09 20:28 ` Ulrich Drepper
2010-04-10  4:39 ` Ulrich Drepper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3sk74lk9w.fsf@hase.home \
    --to=schwab@redhat.com \
    --cc=libc-hacker@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).