From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2167 invoked by alias); 9 Apr 2010 15:26:32 -0000 Received: (qmail 2147 invoked by uid 22791); 9 Apr 2010 15:26:31 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 15:26:22 +0000 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39FQLJV018118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 9 Apr 2010 11:26:21 -0400 Received: from hase.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39FQJ5H027931 for ; Fri, 9 Apr 2010 11:26:20 -0400 From: Andreas Schwab To: libc-hacker@sourceware.org Subject: [PATCH] Fix crash in nscd GETAI call X-Yow: .. I want FORTY-TWO TRYNEL FLOATATION SYSTEMS installed within SIX AND A HALF HOURS!!! Date: Fri, 09 Apr 2010 15:26:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00009.txt.bz2 Testcase: getent ahosts irc.freenode.net Andreas. 2010-04-09 Andreas Schwab * nscd/aicache.c (addhstaiX): Don't crash on missing canonical name. --- nscd/aicache.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/nscd/aicache.c b/nscd/aicache.c index 992357d..1b3a7ee 100644 --- a/nscd/aicache.c +++ b/nscd/aicache.c @@ -166,7 +166,7 @@ addhstaiX (struct database_dyn *db, int fd, request_header *req, addrslen += IN6ADDRSZ; } canon = at->name; - canonlen = strlen (canon) + 1; + canonlen = canon == NULL ? 0 : strlen (canon) + 1; total = sizeof (*dataset) + naddrs + addrslen + canonlen; -- 1.7.0.1 -- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."