From: Andreas Jaeger <aj@suse.de>
To: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: fix sched_setaffinity
Date: Fri, 09 Apr 2004 07:35:00 -0000 [thread overview]
Message-ID: <m3smfdppry.fsf@gromit.moeb> (raw)
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
We cannot use a function call inside INTERNAL_SYSCALL, the macro does
not expands its arguments correctly. This has been noticed on x86-64
(thanks Andreas Schwab and Thorsten Kukuk) but it should be a problem
on other architectures also.
Ok to commit the appended patch?
Andreas
2004-04-09 Andreas Jaeger <aj@suse.de>
* sysdeps/unix/sysv/linux/sched_setaffinity.c
(__sched_setaffinity_new): Do not use a call in INTERNAL_SYSCALL.
============================================================
Index: sysdeps/unix/sysv/linux/sched_setaffinity.c
--- sysdeps/unix/sysv/linux/sched_setaffinity.c 29 Mar 2004 21:59:17 -0000 1.4
+++ sysdeps/unix/sysv/linux/sched_setaffinity.c 9 Apr 2004 07:30:29 -0000
@@ -40,8 +40,9 @@ __sched_setaffinity_new (pid_t pid, size
size_t psize = 128;
void *p = alloca (psize);
+ pid_t pid = getpid ();
- while (res = INTERNAL_SYSCALL (sched_getaffinity, err, 3, getpid (),
+ while (res = INTERNAL_SYSCALL (sched_getaffinity, err, 3, pid,
psize, p),
INTERNAL_SYSCALL_ERROR_P (res, err)
&& INTERNAL_SYSCALL_ERRNO (res, err) == EINVAL)
--
Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
reply other threads:[~2004-04-09 7:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3smfdppry.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).