public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: Ulrich Drepper <drepper@redhat.com>
Cc: GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Re: cpuset_t interfaces
Date: Thu, 18 Mar 2004 06:06:00 -0000	[thread overview]
Message-ID: <m3u10mbsep.fsf@gromit.moeb> (raw)
In-Reply-To: <40593A5E.2090500@redhat.com> (Ulrich Drepper's message of "Wed, 17 Mar 2004 21:57:50 -0800")

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

Ulrich Drepper <drepper@redhat.com> writes:

> I intend to change the interfaces taking a cpuset_t parameter.
> Currently we have
>
> extern int pthread_attr_setaffinity_np (pthread_attr_t *__attr,
>                                         __const cpu_set_t *__cpuset);
> extern int pthread_attr_getaffinity_np (__const pthread_attr_t *__attr,
>                                         cpu_set_t *__cpuset);
>
> and the sched_[sg]etaffinity interfaces which have no prototype yet.
>
> The problem is the limited cpuset_t size.  Just thinking about HT
> multicore processors in multi-processor machines should be enough that
> 1024 virtual processors isn't that hard to reach.
>
>
> Therefore the interface should include a size parameter:
>
> extern int pthread_attr_setaffinity_np (pthread_attr_t *__attr,
>                                         __const cpu_set_t *__cpuset,
>                                         size_t size);
> extern int pthread_attr_getaffinity_np (__const pthread_attr_t *__attr,
>                                         cpu_set_t *__cpuset,
>                                         size_t size);
>
>
> This way the data structure can be expanded if necessary.
>
> The interfaces are in very little use today.  We keep the old interfaces
> and make them simple wrappers with a fixed size of 128 bytes.
>
>
> Unless I hear well-founded objections I'll make the change tomorrow.

Go ahead and make the change.  Since you leave the compatibilty
interface, it should be ok...

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

  reply	other threads:[~2004-03-18  6:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-18  5:57 Ulrich Drepper
2004-03-18  6:06 ` Andreas Jaeger [this message]
2004-03-19  7:40   ` Andreas Jaeger
2004-03-19 19:00     ` Ulrich Drepper
2004-03-20  4:29       ` Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3u10mbsep.fsf@gromit.moeb \
    --to=aj@suse.de \
    --cc=drepper@redhat.com \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).