From: Ulrich Drepper <drepper@cygnus.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: libc-hacker@sourceware.cygnus.com
Subject: Re: [PATCH] Misc fixes
Date: Tue, 28 Dec 1999 08:29:00 -0000 [thread overview]
Message-ID: <m3u2l3f2v2.fsf@localhost.localnet> (raw)
In-Reply-To: <19991228161746.D697@mff.cuni.cz>
You have introduced a larger number of new errors.
> --- libc/locale/programs/ld-time.c.jj Tue Dec 28 11:28:26 1999
> +++ libc/locale/programs/ld-time.c Tue Dec 28 14:37:33 1999
> @@ -219,7 +219,7 @@ time_finish (struct localedef_t *locale,
> if (*str != '+' && *str != '-')
> {
> if (!be_quiet)
> - error (0, 0, _("%s: direction flag in string %d in `era' field"
> + error (0, 0, _("%s: direction flag in string %z in `era' field"
> " is not '+' nor '-'"),
> "LC_TIME", idx + 1);
> /* Default arbitrarily to '+'. */
The z in %z is a modifier. As it is there would be no output
generated for the number. Could you fix all these cases in your
patch? (I konw gcc should warn about this and I have a patch, which I
sent yesterday, but it is not yet approved...)
--
---------------. drepper at gnu.org ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com `------------------------
next prev parent reply other threads:[~1999-12-28 8:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-12-28 7:14 Jakub Jelinek
1999-12-28 8:29 ` Ulrich Drepper [this message]
2002-12-16 10:56 Jakub Jelinek
2002-12-16 11:33 ` Ulrich Drepper
2003-07-12 14:19 Jakub Jelinek
2003-07-12 18:49 ` Ulrich Drepper
2004-10-06 11:41 Jakub Jelinek
2009-03-10 13:42 Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u2l3f2v2.fsf@localhost.localnet \
--to=drepper@cygnus.com \
--cc=jakub@redhat.com \
--cc=libc-hacker@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).