From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulrich Drepper To: Jakub Jelinek Cc: libc-hacker@sourceware.cygnus.com Subject: Re: [PATCH] Misc fixes Date: Tue, 28 Dec 1999 08:29:00 -0000 Message-id: References: <19991228161746.D697@mff.cuni.cz> X-SW-Source: 1999-12/msg00111.html You have introduced a larger number of new errors. > --- libc/locale/programs/ld-time.c.jj Tue Dec 28 11:28:26 1999 > +++ libc/locale/programs/ld-time.c Tue Dec 28 14:37:33 1999 > @@ -219,7 +219,7 @@ time_finish (struct localedef_t *locale, > if (*str != '+' && *str != '-') > { > if (!be_quiet) > - error (0, 0, _("%s: direction flag in string %d in `era' field" > + error (0, 0, _("%s: direction flag in string %z in `era' field" > " is not '+' nor '-'"), > "LC_TIME", idx + 1); > /* Default arbitrarily to '+'. */ The z in %z is a modifier. As it is there would be no output generated for the number. Could you fix all these cases in your patch? (I konw gcc should warn about this and I have a patch, which I sent yesterday, but it is not yet approved...) -- ---------------. drepper at gnu.org ,-. 1325 Chesapeake Terrace Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA Cygnus Solutions `--' drepper at cygnus.com `------------------------