* Testsuite failure in check-localplt
@ 2007-10-08 19:33 Andreas Jaeger
2007-10-08 21:10 ` Roland McGrath
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Jaeger @ 2007-10-08 19:33 UTC (permalink / raw)
To: GNU libc hackers
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On x86-64 I get the following testsuite failure for elf/check-localplt.out:
--- ../scripts/data/localplt-generic.data 2007-08-07 07:35:58.000000000 +0200
+++ - 2007-10-08 16:14:22.828168685 +0200
@@ -2,5 +2,7 @@
libc.so: free
libc.so: malloc
libc.so: memalign
+libc.so: read
libc.so: realloc
+libc.so: write
libm.so: matherr
Should we adjust the testsuite or is there something else to change?
Andreas
--
Andreas Jaeger, Director Platform/openSUSE, aj@suse.de
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Testsuite failure in check-localplt
2007-10-08 19:33 Testsuite failure in check-localplt Andreas Jaeger
@ 2007-10-08 21:10 ` Roland McGrath
2007-10-09 5:50 ` Andreas Jaeger
0 siblings, 1 reply; 3+ messages in thread
From: Roland McGrath @ 2007-10-08 21:10 UTC (permalink / raw)
To: Andreas Jaeger; +Cc: GNU libc hackers
Look for the relocs in libc.so that refer to those symbols. Probably they
should be calling __read, which already has libc_hidden_proto. If they are
in code never reached by ISO C-only, then they could legitimately stick to
read for aesthetic purposes if one really cared, but then you'd need to add
libc_hidden_proto for read in include/unistd.h, which we haven't needed yet.
(If they are in low-level linux-specific code, they might want to be using
INLINE_SYSCALL anyway.)
Thanks,
Roland
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Testsuite failure in check-localplt
2007-10-08 21:10 ` Roland McGrath
@ 2007-10-09 5:50 ` Andreas Jaeger
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Jaeger @ 2007-10-09 5:50 UTC (permalink / raw)
To: Roland McGrath; +Cc: GNU libc hackers
[-- Attachment #1: Type: text/plain, Size: 963 bytes --]
Roland McGrath <roland@redhat.com> writes:
> Look for the relocs in libc.so that refer to those symbols. Probably they
> should be calling __read, which already has libc_hidden_proto. If they are
> in code never reached by ISO C-only, then they could legitimately stick to
> read for aesthetic purposes if one really cared, but then you'd need to add
> libc_hidden_proto for read in include/unistd.h, which we haven't needed yet.
> (If they are in low-level linux-specific code, they might want to be using
> INLINE_SYSCALL anyway.)
Thanks - that helped. It was in eventfd_read and write - and I just
noticed that Uli already committed the obvious fix.
The testsuite passes now for me,
Andreas
--
Andreas Jaeger, Director Platform/openSUSE, aj@suse.de
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-09 5:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-08 19:33 Testsuite failure in check-localplt Andreas Jaeger
2007-10-08 21:10 ` Roland McGrath
2007-10-09 5:50 ` Andreas Jaeger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).