public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Fix warnings in idna.c
Date: Sat, 13 Mar 2004 10:02:00 -0000	[thread overview]
Message-ID: <m3vfl9qd3e.fsf@gromit.moeb> (raw)

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]


I just saw these warnings:

idna.c:445: warning: passing arg 1 of `strlen' from incompatible pointer type
idna.c:445: warning: passing arg 1 of `__strdup' from incompatible pointer type

Ok to commit the appended patch?

Andreas

2004-03-13  Andreas Jaeger  <aj@suse.de>

	* idna.c (idna_to_ascii_4z): Fix warnings.

============================================================
Index: libidn/idna.c
--- libidn/idna.c	13 Mar 2004 06:49:25 -0000	1.2
+++ libidn/idna.c	13 Mar 2004 09:58:24 -0000
@@ -442,7 +442,7 @@ idna_to_ascii_4z (const uint32_t * input
       || (DOTP (input[0]) && input[1] == 0))
     {
 #if defined HAVE_STRDUP || defined _LIBC
-      *output = strdup (input);
+      *output = strdup ((const char *)input);
       return *output == NULL ? IDNA_MALLOC_ERROR : IDNA_SUCCESS;
 #else
       /* Handle implicit zero-length root label. */

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

             reply	other threads:[~2004-03-13 10:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-13 10:02 Andreas Jaeger [this message]
2004-03-13 14:44 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vfl9qd3e.fsf@gromit.moeb \
    --to=aj@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).