From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21979 invoked by alias); 15 Jun 2010 07:49:47 -0000 Received: (qmail 21958 invoked by uid 22791); 15 Jun 2010 07:49:46 -0000 X-SWARE-Spam-Status: No, hits=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Jun 2010 07:49:39 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5F7nbHF002836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Jun 2010 03:49:37 -0400 Received: from hase.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5F7nZO0027690; Tue, 15 Jun 2010 03:49:36 -0400 From: Andreas Schwab To: Ulrich Drepper Cc: libc-hacker@sourceware.org Subject: Re: [PATCH] Fix error handling in getlogin_r References: <4C16CEE0.6010306@redhat.com> X-Yow: Wait.. is this a FUN THING or the END of LIFE in Petticoat Junction?? Date: Tue, 15 Jun 2010 07:49:00 -0000 In-Reply-To: <4C16CEE0.6010306@redhat.com> (Ulrich Drepper's message of "Mon, 14 Jun 2010 17:52:48 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact libc-hacker-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00005.txt.bz2 Ulrich Drepper writes: > What are you trying to fix? Error checking is completely bogus. There is no handling of ERANGE at all. Andreas. -- Andreas Schwab, schwab@redhat.com GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 5EC7 45C6 250E 6F00 984E "And now for something completely different."