From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-hacker-return-7190-listarch-libc-hacker=sources.redhat.com@sources.redhat.com>
Received: (qmail 24980 invoked by alias); 11 Jan 2004 19:28:40 -0000
Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:libc-hacker-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/libc-hacker/>
List-Post: <mailto:libc-hacker@sources.redhat.com>
List-Help: <mailto:libc-hacker-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: libc-hacker-owner@sources.redhat.com
Received: (qmail 24953 invoked from network); 11 Jan 2004 19:28:40 -0000
Received: from unknown (HELO Cantor.suse.de) (195.135.220.2)
  by sources.redhat.com with SMTP; 11 Jan 2004 19:28:40 -0000
Received: from Hermes.suse.de (Hermes.suse.de [195.135.221.8])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by Cantor.suse.de (Postfix) with ESMTP
	id EBB1719CAAB7; Sun, 11 Jan 2004 20:28:39 +0100 (CET)
Received: from aj by arthur.inka.de with local (Exim 4.22)
	id 1AflGH-0004Yq-LU; Sun, 11 Jan 2004 20:28:37 +0100
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Henderson <rth@redhat.com>,
	Glibc hackers <libc-hacker@sources.redhat.com>
Subject: Re: [PATCH] Fix AMD64 backtrace
References: <20040110175049.GM6413@sunsite.ms.mff.cuni.cz>
	<m3smina7f1.fsf@gromit.moeb> <m3n08u93ax.fsf@gromit.moeb>
	<20040111024737.A1431@redhat.com> <m3isji92u3.fsf@gromit.moeb>
	<20040111025223.A2564@redhat.com> <m3eku692mz.fsf@gromit.moeb>
	<m37jzy92hr.fsf@gromit.moeb> <20040111030005.C13258@redhat.com>
	<m3wu7y7k7j.fsf@gromit.moeb>
	<20040111164256.GN6413@sunsite.ms.mff.cuni.cz>
From: Andreas Jaeger <aj@suse.de>
Date: Sun, 11 Jan 2004 19:28:00 -0000
In-Reply-To: <20040111164256.GN6413@sunsite.ms.mff.cuni.cz> (Jakub Jelinek's
 message of "Sun, 11 Jan 2004 17:42:56 +0100")
Message-ID: <m3y8sei8t6.fsf@gromit.moeb>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Rational FORTRAN, linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-SW-Source: 2004-01/txt/msg00044.txt.bz2

--=-=-=
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Content-length: 1222

Jakub Jelinek <jakub@redhat.com> writes:

> On Sun, Jan 11, 2004 at 01:17:52PM +0100, Andreas Jaeger wrote:
>> 	/* Load the new stack pointer, the preserved registers and
>> 	   registers used for passing args.  */
>> 	cfi_def_cfa(%rdi, 0)
>> 	cfi_offset(%rbx,oRBX)
>> 	cfi_offset(%rbp,oRBP)
>> 	cfi_offset(%r12,oR12)
>> 	cfi_offset(%r13,oR13)
>> 	cfi_offset(%r14,oR14)
>> 	cfi_offset(%r15,oR15)
>> 	cfi_offset(%rsp,oRSP)
>> 	cfi_offset(%rip,oRIP)
>>=20=09
>> 	movq	oRSP(%rdi), %rsp
>> 	movq	oRBX(%rdi), %rbx
>> 	movq	oRBP(%rdi), %rbp
>> 	movq	oR12(%rdi), %r12
>> 	movq	oR13(%rdi), %r13
>> 	movq	oR14(%rdi), %r14
>> 	movq	oR15(%rdi), %r15
>>=20
>> 	/* The following ret should return to the address set with
>> 	getcontext.  Therefore push the address on the stack.  */
>> 	movq	oRIP(%rdi), %rcx
>> 	pushq	%rcx
>> 	cfi_adjust_cfa_offset(8)
>
> pushq %rcx modifies %rsp, but current CFI here is %rdi
> which is unchanged.

Thanks!  I'll commit with that change once I get approval for the
sysdeps/generic/sysdep.h change...

Andreas
--=20
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
   GPG fingerprint =3D 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

--=-=-=
Content-Type: application/pgp-signature
Content-length: 188

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQBAAaPlOJpWPMJyoSYRAjEnAJ9sHhMZ2CgGVkdmDKMvxAUufCSv4gCgjESI
N/an8bAylpHSUm2PaQSkFkQ=
=arNW
-----END PGP SIGNATURE-----
--=-=-=--