From: Andreas Schwab <schwab@suse.de>
To: libc-hacker@sources.redhat.com
Subject: Suspect expression in elf/dl-close.c
Date: Sat, 26 Apr 2003 18:47:00 -0000 [thread overview]
Message-ID: <m3znmdyu5u.fsf@whitebox.local> (raw)
The following line in elf/dl-close.c looks wrong:
while (idx - disp > disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0)
I think it should rather be this:
while (idx - disp > (disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0))
Andreas.
2003-04-26 Andreas Schwab <schwab@suse.de>
* elf/dl-close.c (remove_slotinfo): Fix missing parens.
--- elf/dl-close.c.~1.96.~ 2003-04-25 14:15:34.000000000 +0200
+++ elf/dl-close.c 2003-04-26 20:14:45.000000000 +0200
@@ -80,7 +80,7 @@ remove_slotinfo (size_t idx, struct dtv_
return true;
}
- while (idx - disp > disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0)
+ while (idx - disp > (disp == 0 ? 1 + GL(dl_tls_static_nelem) : 0))
{
--idx;
next reply other threads:[~2003-04-26 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-26 18:47 Andreas Schwab [this message]
2003-04-26 20:13 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3znmdyu5u.fsf@whitebox.local \
--to=schwab@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).