From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11390 invoked by alias); 25 Sep 2002 03:24:51 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 11372 invoked from network); 25 Sep 2002 03:24:50 -0000 Received: from unknown (HELO lacrosse.corp.redhat.com) (66.187.233.200) by sources.redhat.com with SMTP; 25 Sep 2002 03:24:50 -0000 Received: from free.redhat.lsd.ic.unicamp.br (aoliva2.cipe.redhat.com [10.0.1.156]) by lacrosse.corp.redhat.com (8.11.6/8.9.3) with ESMTP id g8P3OmP17991; Tue, 24 Sep 2002 23:24:48 -0400 Received: from free.redhat.lsd.ic.unicamp.br (localhost.localdomain [127.0.0.1]) by free.redhat.lsd.ic.unicamp.br (8.12.5/8.12.5) with ESMTP id g8P3Olxr009016; Wed, 25 Sep 2002 00:24:47 -0300 Received: (from aoliva@localhost) by free.redhat.lsd.ic.unicamp.br (8.12.5/8.12.5/Submit) id g8P3Okem009012; Wed, 25 Sep 2002 00:24:46 -0300 To: Ulrich Drepper Cc: Jakub Jelinek , Andreas Jaeger , GNU libc hacker Subject: Re: Fix _exit for Linux References: <20020916185406.G1013@sunsite.ms.mff.cuni.cz> <3D861180.2070903@redhat.com> From: Alexandre Oliva Organization: GCC Team, Red Hat Date: Tue, 24 Sep 2002 20:24:00 -0000 In-Reply-To: <3D861180.2070903@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-SW-Source: 2002-09/txt/msg00062.txt.bz2 --=-=-= Content-length: 832 On Sep 16, 2002, Ulrich Drepper wrote: > Jakub Jelinek wrote: >> There is a difference between libc_hidden_def in .S files and in .c files. >> In .S files it will work even if libc_hidden_proto () was not declared >> in header files (usually the assembly doesn't even include those headers), >> while if you use libc_hidden_{def,weak} without previous libc_hidden_proto, >> things will break badly... > Anyway, the _exit code can now be hidden. The implementation in glibc > itself is now correct if compiled with the new kernel headers so there > is no need to allow it to be overwritten. Let's change > include/unistd.h and add hidden everywhere for _exit. Apologies for the delay. Here's the patch that fixes the mips port such that libc.so doesn't fail to link because __syscall_exit is not defined. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=glibc-mips-_exit.patch Content-length: 834 Index: ChangeLog from Alexandre Oliva * sysdeps/unix/sysv/linux/mips/syscalls.list: Added _exit. Index: sysdeps/unix/sysv/linux/mips/syscalls.list =================================================================== RCS file: /cvs/glibc/libc/sysdeps/unix/sysv/linux/mips/syscalls.list,v retrieving revision 1.32 diff -u -p -r1.32 syscalls.list --- sysdeps/unix/sysv/linux/mips/syscalls.list 13 Sep 2002 07:12:28 -0000 1.32 +++ sysdeps/unix/sysv/linux/mips/syscalls.list 25 Sep 2002 03:23:27 -0000 @@ -82,3 +82,6 @@ sys_lstat lxstat lstat i:sp __syscall_l sys_readv readv readv i:ipi __syscall_readv sys_stat xstat stat i:sp __syscall_stat sys_writev writev writev i:ipi __syscall_writev + +# _exit() does INLINE_SYSCALL (_exit), but we don't have INLINE_SYSCALL +sys_exit _exit exit i:i __syscall_exit --=-=-= Content-length: 289 -- Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org} CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} Free Software Evangelist Professional serial bug killer --=-=-=--