public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
* kernel-features for x86-64
@ 2003-11-13 11:09 Andreas Jaeger
  2003-11-13 16:30 ` Ulrich Drepper
  2003-11-13 16:46 ` Ulrich Drepper
  0 siblings, 2 replies; 4+ messages in thread
From: Andreas Jaeger @ 2003-11-13 11:09 UTC (permalink / raw)
  To: GNU libc hacker

[-- Attachment #1: Type: text/plain, Size: 3136 bytes --]


I've added some defines for x86-64 to kernel-features.

Tested with --enable-kernel=2.6.0 and nptl.

Only failing test is nptl/tst-execstack.out (but that failed before
already).

Ok to commit?

Andreas

2003-11-13  Andreas Jaeger  <aj@suse.de>

	* sysdeps/unix/sysv/linux/kernel-features.h (__ASSUME_TGKILL):
	Define appropriately for x86_64.
	(__ASSUME_UTIMES): Likewise.
	(__ASSUME_FADVISE64_64_SYSCALL): Likewise.
	(__ASSUME_CLONE_THREAD_FLAGS): Likewise.

============================================================
Index: sysdeps/unix/sysv/linux/kernel-features.h
--- sysdeps/unix/sysv/linux/kernel-features.h	16 Aug 2003 06:15:02 -0000	1.67
+++ sysdeps/unix/sysv/linux/kernel-features.h	13 Nov 2003 09:54:12 -0000
@@ -307,9 +307,11 @@
 /* The late 2.5 kernels saw a lot of new CLONE_* flags.  Summarize
    their availability with one define.  The changes were made first
    for i386 and the have to be done separately for the other archs.
-   For ia64, s390*, PPC we pick 2.5.64 as the first version with support.  */
+   For ia64, s390*, PPC, x86-64 we pick 2.5.64 as the first version
+   with support.  */
 #if __LINUX_KERNEL_VERSION >= 132416 \
-    && (defined __ia64__ || defined __s390__ || defined __powerpc__)
+    && (defined __ia64__ || defined __s390__ || defined __powerpc__ \
+	|| defined __x86_64__)
 # define __ASSUME_CLONE_THREAD_FLAGS	1
 #endif
 
@@ -349,17 +351,21 @@
 
 /* The tgkill syscall was instroduced for i386 in 2.5.75.  For Alpha
    it was introduced in 2.6.0-test1 which unfortunately cannot be
-   distinguished from 2.6.0.  */
+   distinguished from 2.6.0.  On x86-64 it was introduced in
+   2.6.0-test3. */
 #if (__LINUX_KERNEL_VERSION >= 132427 && defined __i386__) \
-    || (__LINUX_KERNEL_VERSION >= 132609 && defined __alpha__)
+    || (__LINUX_KERNEL_VERSION >= 132609 && defined __alpha__) \
+    || (__LINUX_KERNEL_VERSION >= 132609 && defined __x86_64__)
 # define __ASSUME_TGKILL	1
 #endif
 
 /* The utimes syscall has been available for some architectures
-   forever.  For x86 it was introduced after 2.5.75.  */
+   forever.  For x86 it was introduced after 2.5.75, for x86-64 in
+   2.6.0-test3.  */
 #if defined __alpha__ || defined __ia64__ || defined __hppa__ \
     || defined __sparc__ \
-    || (__LINUX_KERNEL_VERSION > 132427 && defined __i386__)
+    || (__LINUX_KERNEL_VERSION > 132427 && defined __i386__) \
+    || (__LINUX_KERNEL_VERSION > 132609 && defined __x86_64__)
 # define __ASSUME_UTIMES	1
 #endif
 
@@ -369,7 +375,8 @@
 #endif
 
 /* The fixed version of the posix_fadvise64 syscall appeared in
-   2.6.0-test3.  At least for x86.  */
-#if __LINUX_KERNEL_VERSION >= 132609 && defined __i386__
+   2.6.0-test3.  At least for x86 and amd64.  */
+#if __LINUX_KERNEL_VERSION >= 132609
+     && (defined __i386__ || defined __x86_64__)
 # define __ASSUME_FADVISE64_64_SYSCALL	1
 #endif

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kernel-features for x86-64
  2003-11-13 11:09 kernel-features for x86-64 Andreas Jaeger
@ 2003-11-13 16:30 ` Ulrich Drepper
  2003-11-13 16:46 ` Ulrich Drepper
  1 sibling, 0 replies; 4+ messages in thread
From: Ulrich Drepper @ 2003-11-13 16:30 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hacker

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Jaeger wrote:

> Ok to commit?

Yes.


- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/s7FQ2ijCOnn/RHQRAio9AJ9Za/y+SEj1OLFLTcyKmA4bwFNEtQCeJmsj
mAI7t9/YKeu1jvvdOZtG9PE=
=KHkM
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kernel-features for x86-64
  2003-11-13 11:09 kernel-features for x86-64 Andreas Jaeger
  2003-11-13 16:30 ` Ulrich Drepper
@ 2003-11-13 16:46 ` Ulrich Drepper
  2003-11-13 16:48   ` Andreas Jaeger
  1 sibling, 1 reply; 4+ messages in thread
From: Ulrich Drepper @ 2003-11-13 16:46 UTC (permalink / raw)
  To: Andreas Jaeger; +Cc: GNU libc hacker

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Jaeger wrote:

>  /* The fixed version of the posix_fadvise64 syscall appeared in
> -   2.6.0-test3.  At least for x86.  */
> -#if __LINUX_KERNEL_VERSION >= 132609 && defined __i386__
> +   2.6.0-test3.  At least for x86 and amd64.  */
> +#if __LINUX_KERNEL_VERSION >= 132609
> +     && (defined __i386__ || defined __x86_64__)
>  # define __ASSUME_FADVISE64_64_SYSCALL	1
>  #endif

This part os bogus.  fadvise64_64 is only needed for 32-bit platforms.

- -- 
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/s7Up2ijCOnn/RHQRAgalAKCNPMMgMg481Dfm0C4G/LY1+UXJlgCgn2D+
3CGkxEkKI0VH/4iIevABd+g=
=Zi1b
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: kernel-features for x86-64
  2003-11-13 16:46 ` Ulrich Drepper
@ 2003-11-13 16:48   ` Andreas Jaeger
  0 siblings, 0 replies; 4+ messages in thread
From: Andreas Jaeger @ 2003-11-13 16:48 UTC (permalink / raw)
  To: Ulrich Drepper; +Cc: GNU libc hacker

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

Ulrich Drepper <drepper@redhat.com> writes:

> Andreas Jaeger wrote:
>
>>  /* The fixed version of the posix_fadvise64 syscall appeared in
>> -   2.6.0-test3.  At least for x86.  */
>> -#if __LINUX_KERNEL_VERSION >= 132609 && defined __i386__
>> +   2.6.0-test3.  At least for x86 and amd64.  */
>> +#if __LINUX_KERNEL_VERSION >= 132609
>> +     && (defined __i386__ || defined __x86_64__)
>>  # define __ASSUME_FADVISE64_64_SYSCALL	1
>>  #endif
>
> This part os bogus.  fadvise64_64 is only needed for 32-bit platforms.

I misread that - ok, I revert it.

Thanks,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-11-13 16:48 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-11-13 11:09 kernel-features for x86-64 Andreas Jaeger
2003-11-13 16:30 ` Ulrich Drepper
2003-11-13 16:46 ` Ulrich Drepper
2003-11-13 16:48   ` Andreas Jaeger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).