public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: Fix i386/fcntl.c
Date: Fri, 05 Sep 2003 05:13:00 -0000	[thread overview]
Message-ID: <u8vfs7q0kt.fsf@gromit.moeb> (raw)

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]


building glibc fails with:
../sysdeps/unix/sysv/linux/i386/fcntl.c:36: error: conflicting types for '__fcntl_nocancel'
../include/fcntl.h:12: error: previous declaration of '__fcntl_nocancel'
make[2]: *** [/builds/glibc/gcc-3.4/io/fcntl.o] Error 1

Ok to commit?

Andreas

2003-09-05  Andreas Jaeger  <aj@suse.de>

	* sysdeps/unix/sysv/linux/i386/fcntl.c (__fcntl_nocancel): Change
	prototype to use variable argument lists and get the possible one
	argument via va_arg.


============================================================
Index: sysdeps/unix/sysv/linux/i386/fcntl.c
--- sysdeps/unix/sysv/linux/i386/fcntl.c	4 Sep 2003 13:38:44 -0000	1.17
+++ sysdeps/unix/sysv/linux/i386/fcntl.c	5 Sep 2003 05:12:12 -0000
@@ -32,8 +32,15 @@ int __have_no_fcntl64;
 
 
 int
-__fcntl_nocancel (int fd, int cmd, void *arg)
+__fcntl_nocancel (int fd, int cmd, ...)
 {
+  va_list ap;
+  void *arg;
+
+  va_start (ap, cmd);
+  arg = va_arg (ap, void *);
+  va_end (ap);
+
 #if __ASSUME_FCNTL64 == 0
 # ifdef __NR_fcntl64
   if (! __have_no_fcntl64)

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2003-09-05  5:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-05  5:13 Andreas Jaeger [this message]
2003-09-05  5:33 ` Ulrich Drepper
2003-09-05 10:06   ` Andreas Jaeger
2003-09-07 11:58     ` [PATCH] Fix fcntl on s390x and other arches Jakub Jelinek
2003-09-07 12:07       ` Andreas Jaeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u8vfs7q0kt.fsf@gromit.moeb \
    --to=aj@suse.de \
    --cc=libc-hacker@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).