From: Andreas Jaeger <aj@suse.de>
To: GNU libc hacker <libc-hacker@sources.redhat.com>
Subject: carg, cimag, creal,.. in tgmath.h
Date: Sun, 15 Jun 2003 16:49:00 -0000 [thread overview]
Message-ID: <u8vfv7qoag.fsf@gromit.moeb> (raw)
[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]
We seem to have bugs with carg, cimag, creal, and fabs: They seem
to handle real arguments wrong according to the Dinkumware folks.
Looking at the implementation, I do not understand what's broken with
fabs, but with carg, cimag and creal we only accept complex arguments.
Here's a patch to fix the c* functions. Ok to commit?
Andreas
2003-06-15 Andreas Jaeger <aj@suse.de>
* math/tgmath.h (carg): Handle real arguments.
(conj): Likewise.
(cproj): Likewise.
(cimag): Likewise.
(creal): Likewise.
============================================================
Index: math/tgmath.h
--- math/tgmath.h 3 Mar 2003 19:39:31 -0000 1.20
+++ math/tgmath.h 15 Jun 2003 16:45:13 -0000
@@ -421,21 +421,21 @@
/* Absolute value, conjugates, and projection. */
/* Argument value of Z. */
-#define carg(Val) __TGMATH_UNARY_IMAG_ONLY (Val, carg)
+#define carg(Val) __TGMATH_UNARY_REAL_IMAG (Val, carg, carg)
/* Complex conjugate of Z. */
-#define conj(Val) __TGMATH_UNARY_IMAG_ONLY (Val, conj)
+#define conj(Val) __TGMATH_UNARY_REAL_IMAG (Val, conj, conj)
/* Projection of Z onto the Riemann sphere. */
-#define cproj(Val) __TGMATH_UNARY_IMAG_ONLY (Val, cproj)
+#define cproj(Val) __TGMATH_UNARY_REAL_IMAG (Val, cproj, cproj)
/* Decomposing complex values. */
/* Imaginary part of Z. */
-#define cimag(Val) __TGMATH_UNARY_IMAG_ONLY (Val, cimag)
+#define cimag(Val) __TGMATH_UNARY_REAL_IMAG (Val, cimag, cimag)
/* Real part of Z. */
-#define creal(Val) __TGMATH_UNARY_IMAG_ONLY (Val, creal)
+#define creal(Val) __TGMATH_UNARY_REAL_IMAG (Val, creal, creal)
#endif /* tgmath.h */
--
Andreas Jaeger, SuSE Linux AG, aj@suse.de, http://www.suse.de/~aj
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next reply other threads:[~2003-06-15 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 16:49 Andreas Jaeger [this message]
2003-06-15 17:16 ` Ulrich Drepper
2003-06-15 19:00 ` Andreas Jaeger
2003-06-16 7:59 ` Ulrich Drepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u8vfv7qoag.fsf@gromit.moeb \
--to=aj@suse.de \
--cc=libc-hacker@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).