From: Andreas Jaeger <aj@suse.de>
To: libc-hacker@sourceware.cygnus.com
Subject: Re: Patch for linuxthreads_db/td_thr_getgregs.c
Date: Wed, 12 Jan 2000 23:50:00 -0000 [thread overview]
Message-ID: <u8vh4yl8c5.fsf@gromit.rhein-neckar.de> (raw)
In-Reply-To: <200001121240.NAA26447@hawking.suse.de>
>>>>> Andreas Schwab writes:
> Ulrich Drepper <drepper@cygnus.com> writes:
> |> Andreas Jaeger <aj@suse.de> writes:
> |>
> |> > Uli, if those function declarations are indeed correct (which I
> |> > doubt), you need to change td_thr_getgregs.c accordingly (memset
> |> > (&greg,...)).
> |>
> |> Well, the form I have in the moment is acutally what Solaris has. It
> |> was strange when I saw it but I haven't really spend time looking at
> |> it. But you are right, it cannot be correct.
> The problem is that gregset_t is sometimes an array (i386), sometimes a
> struct (mips). The array decays to a pointer, so you won't see the
> different types, but the sizeof in td_thr_getregs will return the wrong
> value (size of a pointer instead of the whole array).
Uli, you reverted my patch - without fixing the problem. Why? Could
you tell me how to fix the problem? The interface itself seems to be
broken - at least if gregset_t is a struct!
Here's the compiler error again I get on MIPS:
td_thr_getgregs.c: In function `td_thr_getgregs':
td_thr_getgregs.c:38: incompatible types in initialization
td_thr_getgregs.c:38: incompatible type for argument 1 of `memset'
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.rhein-neckar.de
next prev parent reply other threads:[~2000-01-12 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-01-11 19:42 Ulrich Drepper
2000-01-12 4:40 ` Andreas Schwab
2000-01-12 23:50 ` Andreas Jaeger [this message]
[not found] ` <m3g0w2n3pw.fsf@localhost.localnet>
2000-01-13 4:28 ` Andreas Schwab
2000-01-25 14:28 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2000-01-11 11:28 Andreas Jaeger
2000-01-11 12:07 ` Andreas Jaeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=u8vh4yl8c5.fsf@gromit.rhein-neckar.de \
--to=aj@suse.de \
--cc=libc-hacker@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).